Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matter Sensor: check for battery on init #991

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

ctowns
Copy link
Contributor

@ctowns ctowns commented Sep 26, 2023

This moves the battery-checking logic from do_configure to init so that device will not have to be removed and re-added in order to join the correct profile.

This moves the battery-checking logic from do_configure to init
so that device will not have to be removed and re-added in order
to join the correct profile.
@github-actions
Copy link

Test Results

     52 files     342 suites   0s ⏱️
1 621 tests 1 621 ✔️ 0 💤 0
2 806 runs  2 806 ✔️ 0 💤 0

Results for commit 386353a.

@github-actions
Copy link

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 94%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 386353a

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Channel deleted.

@ctowns ctowns requested review from tpmanley and cjswedes September 26, 2023 20:11
@ctowns ctowns merged commit ca34ebe into main Sep 26, 2023
10 checks passed
@ctowns ctowns deleted the matter-sensor-init-profile-check branch September 26, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants