Rolling up main to beta #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
right device label: Cync Full Color A19, Cync Indoor Plug
Update fingerprints.yml for right device label
Pull Request to add Eve MotionBlinds for WWST
Add hub group for SiHAS button
* These changes improve the Eve Energy support - A subdriver has been implemented - It implements the switch, powerMeter, energyMeter and powerConsumptionReport capabilities - It supports the refresh capability - It reads with a timer each minute the current Watt and Watt Accumulated values from custom attributes - The powerMeter and energyMeter values are updated each values or on a refresh - A powerConsumptionReport is sent each 10 minutes by comparing the previous Watt Accumulated value with the current Watt Accumulated value * Eve Energy: Fix 2 unused variable warnings from the Luacheck linter * Use 2-width spaces instead of tabs * Rename the profile to power-energy-powerConsumption * We now store the timer in the device storage and not as a driver-level variable * Don't override the on_off_attr_handler since it is equivalent to the one in the base driver * Rename the profile to power-energy-powerConsumption * Add initial basic tests * Add missing copyright * Remove the matter_handler fallback which is identical to the base driver * Fix formatting * Add unit test to chech that the power meter and energy meter are properly set up when the device is added * Add unit test to check that the timer created in create_poll_schedule triggers the function requestData(). This function will read the standard and custom attributes from the device. * Unit test to check the refresh command * Add a unit test when reporting custom Watt data * Add a unit test when reporting custom Watt accumulated data * Unit test for a report with the custom Watt accumulated attribute sent after 10 minutes * Set the correct creation year in the copyright * Only send the powerConsumptionReport event every 15 minutes instead of every 10 minutes * Eve Energy: Reset the consumption when using the SmartThings command to reset the energy meter * - Set LAST_REPORT_TIME after reading it - Add safety check in case os.time() returns a value before 2001 which could be the cases in unit tests * Add unit tests for the reset command
The matter switch driver was initially written with the assumption that for multi-endpoint devices the endpoints would be sequentially numbered starting from 1. However, this is not a requirement in the matter spec, and devices like composed bridged devices often do not follow this assumption. To address this, endpoints are now queried on device add and then mapped to the corresponding component.
…ic-battery-profile Matter-sensor add support for mains powered sensors
…ndpoint-mapping Matter Switch: fix endpoint to component mapping
Our "default" endpoint logic current returns the lowest endpoint. For matter composed bridged devices, the current "default" endpoint would be the BRIDGED_NODE_DEVICE_TYPE endpoint because it is the lowest endpoint for the bridged device. However, that endpoint does not support the desired clusters, so we want to find the first endpoint that supports our desired cluster and map that to the corresponding component. This should not affect existing behavior because for single endpoint non-bridged devices, the default endpoint would also support the given cluster.
This moves the battery-checking logic from do_configure to init so that device will not have to be removed and re-added in order to join the correct profile.
…efault-endpoint Matter Thermostat: fix default endpoint mapping
…profile-check Matter Sensor: check for battery on init
|
Duplicate profile check: Warning - duplicate profiles detected. |
|
Channel deleted. |
Test Results 52 files ± 0 343 suites +3 0s ⏱️ ±0s Results for commit ca34ebe. ± Comparison against base commit 4ba02f9. This pull request removes 2 and adds 12 tests. Note that renamed tests count towards both. |
|
matter-sensor_coverage.xml
matter-switch_coverage.xml
matter-thermostat_coverage.xml
matter-window-covering_coverage.xml
zigbee-button_coverage.xml
zigbee-switch_coverage.xml
zigbee-window-treatment_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against ca34ebe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.