Skip to content

Commit

Permalink
test: convert sse-util.test to ESM
Browse files Browse the repository at this point in the history
  • Loading branch information
rossiam committed Dec 7, 2023
1 parent 0ab6fc2 commit 3d8a52b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 12 deletions.
2 changes: 1 addition & 1 deletion jest.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const config: JestConfigWithTsJest = {
testMatch: [
// TODO: put this back when all unit tests are converted
// '**/__tests__/**/*.test.ts',
'**/__tests__/lib/(a*|c*|f*|i*|l*|t*|u*|v*).test.ts',
'**/__tests__/lib/*.test.ts',
],
setupFilesAfterEnv: ['jest-extended/all'],
collectCoverageFrom: ['src/**/*.ts'],
Expand Down
16 changes: 7 additions & 9 deletions src/__tests__/lib/sse-util.test.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
import { jest } from '@jest/globals'

import { handleSignals, sseSignals } from '../../lib/sse-util.js'


describe('sse-util', () => {
describe('handleSignals', () => {
it('adds handler for all required Signals', () => {
const handler = jest.fn()
test('handleSignals adds handler for all required Signals', () => {
const handler = jest.fn()

handleSignals(handler)
handleSignals(handler)

sseSignals.forEach(signal => {
expect(process.listeners(signal)).toContain(handler)
})
})
sseSignals.forEach(signal => {
expect(process.listeners(signal)).toContain(handler)
})
})
3 changes: 1 addition & 2 deletions src/lib/sse-util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@ export const sseSignals: NodeJS.Signals[] = ['SIGTERM', 'SIGINT', 'SIGHUP', 'SIG
*
* see: https://nodejs.org/api/process.html#process_signal_events
*/
export function handleSignals(listener: NodeJS.SignalsListener): void {
export const handleSignals = (listener: NodeJS.SignalsListener): void =>
sseSignals.forEach(signal => process.on(signal, listener))
}

/**
* error Event from eventsource doesn't always overlap with MessageEvent
Expand Down

0 comments on commit 3d8a52b

Please sign in to comment.