Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert classes in table-generator.ts to functions #575

Merged

Conversation

rossiam
Copy link
Collaborator

@rossiam rossiam commented Dec 11, 2023

  • converted DefaultTableGenerator and Table classes to functions
    • defaultTableGenerator now takes an options object (with only groupRows as an option) instead of the groupRows boolean
  • updated unit tests, including adding a little more coverage

Copy link

changeset-bot bot commented Dec 11, 2023

⚠️ No Changeset found

Latest commit: 80f3680

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rossiam rossiam merged commit d22f669 into SmartThingsCommunity:yargs Dec 11, 2023
4 checks passed
@rossiam rossiam deleted the no-class-table-generator branch December 11, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants