refactor: consolidate all choose function stuff in util-utils.ts

[rossiam]

Moved all the supporting types and variables for createChooseFn into the same file as createChooseFn. Not sure why I didn't do this when I created createChooseFn. Also updated affected unit tests.

[changeset-bot]

⚠️ No Changeset found

Latest commit: a60e2f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[rossiam]

I've recently learned about this type marker (even though it's been around a while!) and have started using it in the PR but I'm realizing now that I've done so rather inconsistently. I plan to do better in the next PR and then open up a discussion with the team in standup to talk about it.

[Sitlintac]

I checked the Jest documentation but I'm still not quite sure about something. Is this in fact checking that toStringMock was called exactly once with no parameters? Or is it not checking parameters since none were supplied?

[rossiam]

A call to a With function that doesn't check the With seems rather silly so checking for no arguments is the only thing that makes sense to me. It's easy enough to test though; I just removed the argument from a call that had one and I get an error. Here's the output when I remove the argument from line 192 above:

 FAIL  src/__tests__/lib/command/util/apps-util.test.ts
  ● buildTableOutput › creates new table with correct options and adds settings

    expect(received).toHaveBeenCalledExactlyOnceWith(expected)

    Expected mock function to have been called exactly once with [], but it was called with ["setting", "setting value"]

      190 | 			expect.objectContaining({ head: ['Key', 'Value'] }),
      191 | 		)
    > 192 | 		expect(pushMock).toHaveBeenCalledExactlyOnceWith()
          | 		                 ^
      193 | 		expect(toStringMock).toHaveBeenCalledExactlyOnceWith()
      194 | 	})
      195 | })

      at Object.<anonymous> (src/__tests__/lib/command/util/apps-util.test.ts:192:20)

Test Suites: 1 failed, 2 passed, 3 total
Tests:       1 failed, 58 passed, 59 total
Snapshots:   0 total
Time:        2.992 s, estimated 6 s
Ran all test suites related to changed files.