Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move deviceprofiles command to yargs #630

Merged
merged 1 commit into from
Oct 3, 2024
Merged

refactor: move deviceprofiles command to yargs #630

merged 1 commit into from
Oct 3, 2024

Conversation

rossiam
Copy link
Collaborator

@rossiam rossiam commented Oct 2, 2024 •
edited
Loading

  • moved deviceprofiles command to yargs
  • moved buildTableOutput function in deviceprofiles-util module to yargs (used by the command)
  • updated/added unit tests for moved code
  • added a couple more things to table-mock test module

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3f34124

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rossiam rossiam force-pushed the yargs-deviceprofiles branch from 7f9c3eb to 8baaaff Compare October 3, 2024 16:15
@rossiam rossiam force-pushed the yargs-deviceprofiles branch from 8baaaff to 3f34124 Compare October 3, 2024 16:16
@rossiam rossiam marked this pull request as ready for review October 3, 2024 16:18
@rossiam rossiam changed the title Yargs deviceprofiles refactor: move deviceprofiles command to yargs Oct 3, 2024
julieganzer
julieganzer approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@julieganzer julieganzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rossiam rossiam merged commit 0353d88 into SmartThingsCommunity:yargs Oct 3, 2024
4 checks passed
@rossiam rossiam deleted the yargs-deviceprofiles branch October 3, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julieganzer julieganzer julieganzer approved these changes

@bflorian bflorian Awaiting requested review from bflorian

@dstanich dstanich Awaiting requested review from dstanich

@lecorsedegironde lecorsedegironde Awaiting requested review from lecorsedegironde

@Sitlintac Sitlintac Awaiting requested review from Sitlintac

@Doczillar Doczillar Awaiting requested review from Doczillar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossiam @julieganzer