test: add unit tests for getSchemaAppEnsuringOrganization #646
Conversation
|
| import type { clipToMaximum, fatalError } from '../../../../lib/util.js' | ||
| import type { APICommand } from '../../../../lib/command/api-command.js' | ||
| import type { chooseOrganization, organizationDef } from '../../../../lib/command/util/organizations-util.js' | ||
| import { chooseOrganization, organizationDef } from '../../../../lib/command/util/organizations-util.js' |
There was a problem hiding this comment.
Here and on line 14 (import type { stdinIsTTY, stdoutIsTTY }...) the import statement isn't what I expected with regard to type and not type
There was a problem hiding this comment.
Yeah, I missed type on a bunch of things here. Fixed now.
| expect(cloneMock).not.toHaveBeenCalled() | ||
| }) | ||
|
|
||
| it('sets and organization when app found without an organization', async () => { |
There was a problem hiding this comment.
Little typo: "an organization"
There was a problem hiding this comment.
Good catch. Fixed.
| it('sets and organization when app found without an organization', async () => { | ||
| chooseOrganizationMock.mockResolvedValueOnce('organization-id-1') | ||
| apiOrganizationsGetMock.mockResolvedValueOnce(organization1) | ||
| // TODO: maybe use an "updated organization" here and in corresponding expect below |
There was a problem hiding this comment.
Just checking: this TODO is really for future work and not just an idea that you considered and rejected, right?
There was a problem hiding this comment.
Didn't mean to leave that in. Removed now.
rossiam
force-pushed
the
new-schema-utils-tests
branch
from
7ebda67 to
f9c45de
Compare
getSchemaAppEnsuringOrganizationfunction.APICommand(which already default toAPICommandFlags).