Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert apps:authorize command to yargs #648

Merged
merged 1 commit into from
Dec 2, 2024
Merged

refactor: convert apps:authorize command to yargs #648

merged 1 commit into from
Dec 2, 2024

Conversation

rossiam
Copy link
Collaborator

@rossiam rossiam commented Nov 26, 2024

Converted apps:authorize command to yargs.

@rossiam rossiam requested a review from a team November 26, 2024 15:26
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6e8e829

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sitlintac
Sitlintac approved these changes Nov 27, 2024
View reviewed changes
src/__tests__/commands/apps/authorize.test.ts Outdated
expect(consoleLogSpy).toHaveBeenCalledWith('permissions updated')
})

it('passes on principle and statement', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "principal"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed. Thanks!

@rossiam rossiam force-pushed the apps-authorize-yargs branch from 1ef0a3a to 6e8e829 Compare December 2, 2024 14:39
@rossiam rossiam merged commit cea8952 into SmartThingsCommunity:yargs Dec 2, 2024
4 checks passed
@rossiam rossiam deleted the apps-authorize-yargs branch December 2, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sitlintac Sitlintac Sitlintac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossiam @Sitlintac