DEVORTEX-5439 add webhooks api #125
Conversation
| interface SubscriptionSecretDto { | ||
| payloadSecret: string; | ||
| } | ||
|
|
||
| export { SubscriptionSecretDto }; |
There was a problem hiding this comment.
no actions points: weird naming. it's already clear this secret is in payload.
| import { CreateUpdateSubscriptionParameters } from "./create-update-subscription-parameters"; | ||
| import { SubscriptionEvent } from "./subscription-event"; | ||
|
|
||
| export class UpdateSubscriptionParameters extends CreateUpdateSubscriptionParameters { |
There was a problem hiding this comment.
Maybe rename CreateUpdateSubscriptionParameters to CreateSubscriptionParameters since you have separate class for updating?
There was a problem hiding this comment.
UpdateSubscriptionParameters doesn’t support all methods available in CreateSubscriptionParameters, so we can't inherit one from the other directly.
Instead, both CreateSubscriptionParameters and UpdateSubscriptionParameters extend a common base class.
| getSubscriptions( | ||
| accountUid: string | ||
| ): Promise<SmartlingListResponse<SubscriptionDto>> { | ||
| return this.makeRequest( | ||
| "get", | ||
| `${this.entrypoint}/accounts/${accountUid}/subscriptions` | ||
| ); | ||
| } |
There was a problem hiding this comment.
Does this endpoint support pagination?
There was a problem hiding this comment.
No, the endpoint returns the full list of subscriptions, but it's capped to a small fixed number.
| enableSubscription( | ||
| accountUid: string, | ||
| subscriptionUid: string | ||
| ): Promise<void> { | ||
| return this.makeRequest( | ||
| "post", | ||
| `${this.entrypoint}/accounts/${accountUid}/subscriptions/${subscriptionUid}/enable` | ||
| ); | ||
| } | ||
|
|
||
| disableSubscription( | ||
| accountUid: string, | ||
| subscriptionUid: string | ||
| ): Promise<void> { | ||
| return this.makeRequest( | ||
| "post", | ||
| `${this.entrypoint}/accounts/${accountUid}/subscriptions/${subscriptionUid}/disable` | ||
| ); | ||
| } | ||
|
|
||
| testSubscription( | ||
| accountUid: string, | ||
| subscriptionUid: string | ||
| ): Promise<void> { | ||
| return this.makeRequest( | ||
| "post", | ||
| `${this.entrypoint}/accounts/${accountUid}/subscriptions/${subscriptionUid}/test` | ||
| ); | ||
| } |
There was a problem hiding this comment.
I remember initial arch review but have you guys arranged API review? These verbs in endpoints look strange (test/enable/disable/etc)
There was a problem hiding this comment.
@dnetrebenko-smartling could you please answer?
No description provided.