Dependency bump #22
Open
Dependency bump #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TrojanerHD
commented
Aug 29, 2023
•
TrojanerHD
commented
- Upgrade gradle wrapper
- Upgrade dependencies and plugins
- Force trailing commas
- Set compatibility version of java instead of pinning the JDK version using toolchain
|
Before I review this in detail: I think for this project it would be good to remain backwards compatible with older Java versions. I would like to continue supporting Java 8 if it does not become too much of a pain. That way consumers with older projects can continue using this. |
rubengees
requested changes
Oct 5, 2023
| diffUtilsVersion = '3.0' | ||
| alphanumericComparatorVersion = "1.4.1" | ||
|
|
||
| bootstrapVersion = '4.6.0' | ||
| jqueryVersion = '3.6.0' | ||
| bootstrapVersion = '5.3.1' |
There was a problem hiding this comment.
If we want to upgrade this we also need to update the frontend since this version is not backwards compatible.
Comment on lines
+28
to
+32
| jqueryVersion = '3.7.0' | ||
| popperVersion = '1.16.1' | ||
| fontAwesomeVersion = '5.15.4' | ||
| diff2htmlVersion = '3.1.7' | ||
| markedVersion = '2.0.6' | ||
| fontAwesomeVersion = '6.4.2' | ||
| diff2htmlVersion = '3.4.29' | ||
| markedVersion = '7.0.3' |
There was a problem hiding this comment.
Also manually test the other frontend dependencies.
Comment on lines
+106
to
+107
| "\"${result.description}\"" | ||
| .replace("\n", HTML_LINE_ENDING) |
There was a problem hiding this comment.
We can have this in a single line now I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.