Fix IFS compile warnings/errors (#2673)

This PR improves the IFS `ObjectBuffer` implementation to fix 'hidden virtual method' warnings produced by more recent compilers. The class is just a helper/wrapper with a set of custom 'write' methods, so shouldn't have used inheritance in the first place. Also fixes an 'uninitialised variable' warning in the `Spiffs` IFS library, identified by running IFS integration tests through valgrind.
SmingHub · Oct 12, 2023 · ee881ef · ee881ef
1 parent 6591e72
commit ee881ef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Sming/Components/IFS b/Sming/Components/IFS
diff --git a/Sming/Libraries/Spiffs/src/include/IFS/SPIFFS/FileSystem.h b/Sming/Libraries/Spiffs/src/include/IFS/SPIFFS/FileSystem.h
@@ -137,7 +137,7 @@ class FileSystem : public IFileSystem
 	Storage::Partition partition;
 	IProfiler* profiler{nullptr};
 	SpiffsMetaBuffer metaCache[SPIFF_FILEDESC_COUNT];
-	spiffs fs;
+	spiffs fs{};
 	uint8_t workBuffer[LOG_PAGE_SIZE * 2];
 	spiffs_fd fileDescriptors[SPIFF_FILEDESC_COUNT];
 	uint8_t cache[CACHE_SIZE];
+6 −6		src/FWFS/ArchiveStream.cpp
+18 −5		src/include/IFS/FWFS/ObjectBuffer.h