Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]rboot missing RBOOT_BIG_FLASH definition #2730

Closed
wants to merge 2 commits into from
Closed

[WIP]rboot missing RBOOT_BIG_FLASH definition #2730

wants to merge 2 commits into from

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Mar 12, 2024 •
edited
Loading

rboot missing RBOOT_BIG_FLASH definition
3deb1a6 
Bootloader code never gets `BOOT_BIG_FLASH` definition.
This is evident by unexpected absence of `rBoot Option: Big flash` during (non-silent) boot.
Looks like this crept in with SmingHub#1817.
@SmingHub SmingHub deleted a comment from what-the-diff bot Mar 12, 2024
@mikee47
Copy link
Contributor Author

mikee47 commented Mar 12, 2024 •
edited
Loading

Reviewing the current rboot.c we could probably remove flashsize calculation (and BOOT_BIG_FLASH) altogether. That would mean this fix is only required for 4.2 LTS.

@mikee47 mikee47 changed the title rboot missing RBOOT_BIG_FLASH definition [WIP]rboot missing RBOOT_BIG_FLASH definition Mar 12, 2024
Update rboot
f10d342 
Remove redundant `flashsize` calculation (uses partition table)
Update version string
@mikee47 mikee47 closed this Mar 12, 2024
@mikee47 mikee47 deleted the fix/rboot-big-flash branch March 12, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikee47