Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix esp8266 pwm #2889

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fix esp8266 pwm #2889

merged 2 commits into from
Oct 18, 2024

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Oct 17, 2024

Fix bug introduced in #2752 where PWM doesn't initialise GPIO correctly. See #2888.

Copy link

what-the-diff bot commented Oct 17, 2024

PR Summary

  • Removal of Peripheral Header File Inclusion
    The reference to "peripheral.h" in the pins_arduino.h file has been taken out. This is a good thing because it potentially decreases the complexity of the code and removes any unneeded dependencies, making the code more maintainable.

  • Introduction of GPIO Pin Function Mapping Array
    An array named gpioPinFunc has been added to the HardwarePWM.cpp file. The purpose of this array is to define how the various GPIO (General Purpose Input Output) pins on the device should behave, specifically outlining which functions they should perform.

  • Update to Pin Assignment Logic
    The way we assign functions to pins has been updated. Now, instead of using the old esp8266_gpioToFn[pin] mapping, we're using the new gpioPinFunc[pin] array introduced in this update. This should provide us with a more direct and efficient way of mapping functions to GPIO pins.

@mikee47 mikee47 added Bug and removed Bug labels Oct 18, 2024
@slaff slaff added this to the 6.0.0 milestone Oct 18, 2024
@slaff slaff merged commit 360826a into SmingHub:develop Oct 18, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants