Partial container API improvements #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kburov-sc
force-pushed
the
kb-partial-sugar
branch
from
4142cb5
to
18fab13
Compare
kburov-sc
commented
Sep 9, 2024
| token: Token, | ||
| cls: InjectableClass<Services, Service, Tokens> | ||
| ): Container<AddService<Services, Token, Service>> { |
There was a problem hiding this comment.
This was almost complete duplicate of providesService method, which we can now reuse.
kburov-sc
commented
Sep 9, 2024
| const factories = { ...this.factories, [token]: factory }; | ||
| return new Container(factories as unknown as MaybeMemoizedFactories<AddService<Services, Token, Service>>); | ||
| } | ||
| providesValue = <Token extends TokenType, Service>(token: Token, value: Service) => |
There was a problem hiding this comment.
re-using providesService
kburov-sc
commented
Sep 9, 2024
| appendValue<Token extends TokenType, Service>(token: Token, value: Service): Container<any> { | ||
| return this.providesService(ConcatInjectable(token, () => value)); | ||
| } | ||
| ) => this.providesService(ConcatInjectable(token, () => value)) as Container<Services>; |
There was a problem hiding this comment.
re-using providesService
kburov-sc
commented
Sep 9, 2024
| @@ -407,13 +407,6 @@ export class Container<Services = {}> { | |||
| return this.providesService(fnOrContainer); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Duplicate comment
| /** | ||
| * Creates an Injectable factory function for an InjectableClass. | ||
| * | ||
| * @param token Token identifying the Service. |
There was a problem hiding this comment.
Let's provide an example how this can be used similarly how we do that for other exported stuff here
| constructor(public testService: string) {} | ||
| } | ||
|
|
||
| describe("and the new Service does not override", () => { |
There was a problem hiding this comment.
please replace describe with test here and in other case. the expectation should be inside test block.
|
|
||
| describe("and the new Service does not override", () => { | ||
| const partialContainer = new PartialContainer({}).providesClass("NewTestService", NewTestService); | ||
| expect(dependenciesContainer.provides(partialContainer).get("NewTestService")).toBeInstanceOf(NewTestService); |
There was a problem hiding this comment.
I think we need an expectation that a dependency is missing, something line:
const partialContainer = new PartialContainer({}).providesClass("NewTestService", NewTestService);
// @ts-expect-error
expect(() => Container.provides(partialContainer).get("NewTestService")).toThrow(
'[Container::get] Could not find Service for Token "TestService". ' +
"This should've caused a compile-time error. If the Token is 'undefined', " +
"check all your calls to the Injectable function. Make sure you define dependencies " +
"using string literals or string constants that are definitely initialized before the call to Injectable."
);Would be nice to have that for other provide* methods on partial container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
providesValueandprovidesClassto thePartialContainerAPI