Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not fail operator if an unknown job found in cluster #132

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

s-vitaliy
Copy link
Contributor

Fixes/Implements #.

Scope

Implemented:

  • Awesome new feature
  • And another awesome new feature

Additional changes:

  • Refactored AwesomeClass
  • Removed deprecated AnotherClass and get_awesomeness from AwesomeClass

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy requested a review from a team as a code owner October 9, 2024 14:54
Copy link

github-actions bot commented Oct 9, 2024

Coverage after merging fix-job-error-handling into main will be

71.60%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/Exceptions
   JobListenerException.cs0%100%0%0%14–16
src/Extensions
   KubernetesObjectExtensions.cs100%100%100%100%
   StreamClassPhaseExtensions.cs83.33%50%100%100%17
   V1JobExtensions.cs76.97%59.09%88.24%83.52%106, 106, 127, 127, 132, 137, 137, 142, 147, 147, 152, 53–54, 54, 54, 54, 54–56, 59–60, 69, 69, 76, 84–85, 85, 85, 85, 85–88
src/Models/Api
   CustomResourceApiRequest.cs100%100%100%100%
   ResourceEvent.cs100%100%100%100%
src/Models/Base
   KubernetesCommands.cs75%100%75%75%29–30
src/Models/Commands
   StreamClassCommands.cs75%100%75%75%60
   StreamDefinitionCommands.cs89.74%100%92.86%88%126–128
   StreamingJobCommands.cs100%100%100%100%
src/Models/Resources/Status/V1Alpha1
   V1Alpha1StreamStatus.cs100%100%100%100%
src/Models/Resources/StreamClass/Base
   IStreamClass.cs100%100%100%100%
src/Models/Resources/StreamClass/V1Beta1
   V1Beta1StreamClassSpec.cs85.71%100%85.71%85.71%12
src/Models/Resources/StreamDefinitions/Base
   IStreamDefinition.cs90%83.33%100%100%29
src/Services/CommandHandlers
   AnnotationCommandHandler.cs47.89%16.67%75%49.18%39–42, 59–62, 67–71, 71, 71–78, 78, 78–90
   StreamingJobCommandHandler.cs88.54%72.22%100%91.67%111, 111, 114, 50, 60, 83–88
   UpdateStatusCommandHandler.cs91.14%75%100%91.43%102–103, 44–47, 85
src/Services/HostedServices
   HostedStreamingJobOperatorService.cs0%0%0%0%16–24, 27–29, 29, 29–36, 39–42
src/Services/Metrics
   DeclaredMetrics.cs67.65%60%75%70%26–31, 33, 33, 33, 33
   MetricsReporter.cs73.53%50%75%75%36–39, 50–53
src/Services/Metrics/Actors
   MetricsPublisherActor.cs53.57%25%55.56%55.81%25, 42, 48, 53, 72–78, 82–83, 83, 83–86, 92–95
src/Services/Operators
   StreamClassOperatorService.cs93.06%62.50%100%96.55%103, 105, 80, 80, 84
   StreamingJobOperatorService.cs61.71%54.55%60%64.46%100–103, 103, 103, 103, 103–110, 145–149, 154, 158, 158, 158, 163–164, 168–170, 170, 170–175, 178–181, 184–187, 82, 82, 82, 84, 87, 92–95, 95, 95–97, 97, 97, 97, 97–99
   StreamOperatorService.cs82.13%73.08%90.91%84.72%107–111, 157–158, 158, 158, 160–161, 170, 178–182, 198, 200, 204, 204, 204, 210–211, 71–72, 72, 72–73, 77–79, 96–99
src/Services/Repositories/CustomResources
   StreamClassRepository.cs100%100%100%100%
   StreamDefinitionRepository.cs0%100%0%0%21–24, 29–34, 36–39, 42–49, 51–52, 56–61
   StreamingJobTemplateRepository.cs0%0%0%0%21–28, 32–34, 34, 34, 34, 34, 34, 34, 34, 34–37, 40–54
src/Services/Repositories/StreamingJob
   StreamingJobRepository.cs58.82%100%66.67%57.14%33–38

@s-vitaliy s-vitaliy marked this pull request as draft October 10, 2024 08:34
Copy link

Coverage after merging fix-job-error-handling into main will be

71.60%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/Exceptions
   JobListenerException.cs0%100%0%0%14–16
src/Extensions
   KubernetesObjectExtensions.cs100%100%100%100%
   StreamClassPhaseExtensions.cs83.33%50%100%100%17
   V1JobExtensions.cs76.97%59.09%88.24%83.52%106, 106, 127, 127, 132, 137, 137, 142, 147, 147, 152, 53–54, 54, 54, 54, 54–56, 59–60, 69, 69, 76, 84–85, 85, 85, 85, 85–88
src/Models/Api
   CustomResourceApiRequest.cs100%100%100%100%
   ResourceEvent.cs100%100%100%100%
src/Models/Base
   KubernetesCommands.cs75%100%75%75%29–30
src/Models/Commands
   StreamClassCommands.cs75%100%75%75%60
   StreamDefinitionCommands.cs89.74%100%92.86%88%126–128
   StreamingJobCommands.cs100%100%100%100%
src/Models/Resources/Status/V1Alpha1
   V1Alpha1StreamStatus.cs100%100%100%100%
src/Models/Resources/StreamClass/Base
   IStreamClass.cs100%100%100%100%
src/Models/Resources/StreamClass/V1Beta1
   V1Beta1StreamClassSpec.cs85.71%100%85.71%85.71%12
src/Models/Resources/StreamDefinitions/Base
   IStreamDefinition.cs90%83.33%100%100%29
src/Services/CommandHandlers
   AnnotationCommandHandler.cs47.89%16.67%75%49.18%39–42, 59–62, 67–71, 71, 71–78, 78, 78–90
   StreamingJobCommandHandler.cs88.54%72.22%100%91.67%111, 111, 114, 50, 60, 83–88
   UpdateStatusCommandHandler.cs91.14%75%100%91.43%102–103, 44–47, 85
src/Services/HostedServices
   HostedStreamingJobOperatorService.cs0%0%0%0%16–24, 27–29, 29, 29–36, 39–42
src/Services/Metrics
   DeclaredMetrics.cs67.65%60%75%70%26–31, 33, 33, 33, 33
   MetricsReporter.cs73.53%50%75%75%36–39, 50–53
src/Services/Metrics/Actors
   MetricsPublisherActor.cs53.57%25%55.56%55.81%25, 42, 48, 53, 72–78, 82–83, 83, 83–86, 92–95
src/Services/Operators
   StreamClassOperatorService.cs93.06%62.50%100%96.55%103, 105, 80, 80, 84
   StreamingJobOperatorService.cs61.71%54.55%60%64.46%100–103, 103, 103, 103, 103–110, 145–149, 154, 158, 158, 158, 163–164, 168–170, 170, 170–175, 178–181, 184–187, 82, 82, 82, 84, 87, 92–95, 95, 95–97, 97, 97, 97, 97–99
   StreamOperatorService.cs82.13%73.08%90.91%84.72%107–111, 157–158, 158, 158, 160–161, 170, 178–182, 198, 200, 204, 204, 204, 210–211, 71–72, 72, 72–73, 77–79, 96–99
src/Services/Repositories/CustomResources
   StreamClassRepository.cs100%100%100%100%
   StreamDefinitionRepository.cs0%100%0%0%21–24, 29–34, 36–39, 42–49, 51–52, 56–61
   StreamingJobTemplateRepository.cs0%0%0%0%21–28, 32–34, 34, 34, 34, 34, 34, 34, 34, 34–37, 40–54
src/Services/Repositories/StreamingJob
   StreamingJobRepository.cs58.82%100%66.67%57.14%33–38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant