Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement implicit conversion in the convenient way #108

Draft
wants to merge 1 commit into
base: scala
Choose a base branch
from

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Dec 4, 2024

Part of #61

Scope

In this pull request the SchemaConversions object is being replaced with a more convenient way to convert types using the Conversion typeclass.

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy requested a review from a team as a code owner December 4, 2024 13:25
Copy link

github-actions bot commented Dec 4, 2024

File Coverage
All files 60%
models/ArcaneSchema.scala 61%
models/app/StreamContext.scala 0%
models/querygen/MergeQuery.scala 85%
services/app/PosixStreamLifetimeService.scala 0%
services/app/StreamRunnerServiceImpl.scala 0%
services/app/logging/Enrichers.scala 0%
services/app/logging/Enrichers.scala 0%
services/app/logging/Enrichers.scala 0%
services/app/logging/base/Enricher.scala 0%
services/consumers/JdbcConsumer.scala 0%
services/consumers/JdbcConsumer.scala 0%
services/lakehouse/IcebergS3CatalogWriter.scala 78%
services/lakehouse/IcebergCatalogCredential.scala 56%
services/lakehouse/SchemaConversions.scala 17%
services/mssql/MsSqlDataProvider.scala 87%
services/mssql/MsSqlDataProvider.scala 82%
services/mssql/MsSqlConnection.scala 75%
services/mssql/MsSqlConnection.scala 64%
services/mssql/query/LazyQueryResult.scala 79%
services/mssql/query/ScalarQueryResult.scala 66%
services/storage/models/amazon/AmazonS3StoragePath.scala 80%
services/streaming/IcebergConsumer.scala 0%
services/streaming/BackfillGroupingProcessor.scala 0%
services/streaming/VersionedDataGraphBuilder.scala 66%
services/streaming/BackfillDataGraphBuilder.scala 0%

Minimum allowed coverage is 40%

Generated by 🐒 cobertura-action against 2d28952

@s-vitaliy s-vitaliy marked this pull request as draft December 5, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant