Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getChanges method for Arcane SQL server #75

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Nov 5, 2024

Part of #61

Scope

Implemented:

  • The getChanges method in the MsSqlConnection that reads changes from the database.

Additional changes:

  • The QueryRestult trait was moved to another file
  • The ScalarQueryResult class was addded
  • The AutoClosable interface implementation was moved to the common trait ResultSetOwner from QueryResult implementations.

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy requested a review from a team as a code owner November 5, 2024 09:23
@s-vitaliy s-vitaliy merged commit aee1e61 into scala Nov 5, 2024
2 checks passed
@s-vitaliy s-vitaliy deleted the implement-get-changes branch November 5, 2024 11:14
@s-vitaliy s-vitaliy mentioned this pull request Dec 4, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants