Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ability to use built-in datadog logging support #97

Merged
merged 5 commits into from
Nov 28, 2024

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Nov 27, 2024

Part of #61

Scope

Implemented:

  • Logging to datadog using push mechanism with sl4j
  • Logging to console with simple format

Additional changes:

  • To be able to enrich the sl4j logs created directly and the zio logs we should do the follwoing:
    • append properties to zio logger
    • addend properties to java MDC
      To be able to add that metadata to both log sources in the simple manner, I created the Enircher interface and it's implementations that should be used in main.scala in the logging bootstrap process.

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy requested a review from a team as a code owner November 27, 2024 15:57
# Conflicts:
#	framework/arcane-framework/src/main/scala/services/lakehouse/IcebergS3CatalogWriter.scala
@s-vitaliy s-vitaliy merged commit 368e0a4 into scala Nov 28, 2024
2 checks passed
@s-vitaliy s-vitaliy deleted the logging-stuff branch November 28, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants