Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature v1 auth UI #702

Merged
merged 26 commits into from
Oct 29, 2023
Merged

Feature v1 auth UI #702

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e9a38d1
hoverしてもopacityが変わらないように変更
Oct 10, 2023
4d48939
border-radiusに変数を指定し、marginを調整
Oct 10, 2023
4917fd7
リダイレクトのためにauthorの状態を問わずLoginを表示
Oct 10, 2023
9ac1969
ログイン画面のUIを作成
Oct 10, 2023
676bc0c
モバイル対応を実装
Oct 10, 2023
92a4fd2
Merge branch 'main' into feature-v1-auth-ui
studiokaiji Oct 10, 2023
b9b5168
Update web/src/routes/Login.svelte
studiokaiji Oct 12, 2023
e3d56c8
Merge branch 'main' into feature-v1-auth-ui
SnowCait Oct 17, 2023
46566f6
Merge branch 'main' into feature-v1-auth-ui
SnowCait Oct 20, 2023
aa7a68d
Move directory
SnowCait Oct 20, 2023
ffaab2e
Fix paths
SnowCait Oct 20, 2023
f1595cb
CSS
SnowCait Oct 20, 2023
8185de3
Format
SnowCait Oct 20, 2023
5d7d501
Splash
SnowCait Oct 21, 2023
3563a09
Extract splash screen
SnowCait Oct 21, 2023
a21915c
Fix navigation
SnowCait Oct 21, 2023
b2c1137
Fix test
SnowCait Oct 21, 2023
5224e78
Logo layout
SnowCait Oct 22, 2023
a88b714
Merge pull request #2 from SnowCait/reorganize-directory
studiokaiji Oct 22, 2023
a427571
Merge pull request #3 from SnowCait/splash
studiokaiji Oct 27, 2023
9cef9f7
Hero Messageにemojiを追加
Oct 27, 2023
161f633
heightが十分でない場合にレイアウトが崩れる問題を解決
Oct 27, 2023
6175537
safariでdividerが改行される問題を解決
Oct 27, 2023
4dbbe7d
Hero message
SnowCait Oct 29, 2023
7a44d69
Feedback
SnowCait Oct 29, 2023
fbb94da
Merge pull request #4 from SnowCait/hero-message
studiokaiji Oct 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion web/src/lib/components/ModalDialog.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

<dialog
bind:this={dialog}
class="card"
on:click={tryClose}
on:keyup|stopPropagation={console.debug}
on:close={onClose}
Expand All @@ -40,6 +41,10 @@
<style>
dialog {
border: var(--default-border);
border-radius: 10px;
border-radius: var(--radius);
}

.dialog-content {
margin: 0.5rem;
}
</style>
17 changes: 11 additions & 6 deletions web/src/lib/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
"recommended": "Recommended",
"key": "Login with key",
"create_account": "Create account",
"create": "Create",
"name": "name",
"try_demo": "Try demo",
"login": "Login"
"login": "Login",
"hero-message": "A Liberating Social Network for All.",
"hero-message-sub": "No sudden post restrictions, no disappearing accounts. All you need is just one KEY."
},
"post": "Post",
"follow": "Follow",
"following": "Following",
"editor": {
"editor": {
"post": "Post"
},
"gdpr": {
Expand All @@ -39,5 +39,10 @@
"label": "Analytics",
"description": "Used to control Google Analytics."
}
}
},
"post": "Post",
"follow": "Follow",
"following": "Following",
"cancel": "Cancel",
"or": "OR"
}
14 changes: 9 additions & 5 deletions web/src/lib/i18n/locales/ja.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
"recommended": "推奨",
"key": "鍵でログイン",
"create_account": "アカウントを作成",
"create": "作成",
"name": "名前",
"try_demo": "デモを試す",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここの文言変更したいなと思ってるんですがどうでしょうか？（分かりやすさとデザイン面）

Suggested change
"try_demo": "デモを試す",
"try_demo": "登録せずに見る",

英語だと Try without register とかかな。
アカウント作成ダイアログ内のボタンも register, 登録 に。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

試してみるとか、ログインせずに見るとかいろいろ考えられますよねー…

Copy link
Owner

@SnowCait SnowCait Oct 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そうそう。「デモ」っていうとなんか少し堅苦しい（？）感じがするからもうちょっと気軽に中を覗けるよーって感じの文言にした方がいいかなと思って。

"login": "ログイン"
"login": "ログイン",
"hero-message": "みんなのための、自由なSNS。",
"hero-message-sub": "突然投稿ができなくなることも、アカウントが消えることもない。必要なのは「鍵」ひとつだけ。"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

突然投稿ができなくなることも、アカウントが消えることもない。

やや意味が被ってそうなのでまとめてしまいたいかもです。

必要なのは「鍵」ひとつだけ。

個人的には言い回し好きなんですが、鍵というワードを表に出すと全体的にもう少し npub/nsec を表に出さないと整合性取れなさそうなので出来ればメールアドレス不要のように言い換えたいです。

どういう文言にするのが良さそうか検討中。。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

まとめてもいいんですけど、キャッチコピーとしては短くなるので、どうしようかなという感じです。
文言周りはまたどこかで決めましょう。

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ネガティブ否定系（凍結がない、メアド不要）だけじゃなくてポジティブ系も入れたいかも。
絵文字が使えるとか使い慣れたデザインであるとか。

キャッチコピーとしてそれっぽくできるかは分からないけど…

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

かっこよさは減るけど「凍結のないオープンな環境で絵文字キッチンを楽しもう。」とかでもいいのかなぁ。

},
"post": "投稿",
"follow": "フォロー",
"following": "フォロー中",
"editor": {
"post": "ポストする"
},
Expand All @@ -39,5 +39,9 @@
"label": "アナリティクス",
"description": "Google Analytics に使用されます。"
}
}
},
"post": "投稿",
"follow": "フォロー",
"following": "フォロー中",
"or": "または"
}
2 changes: 1 addition & 1 deletion web/src/routes/+layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@
}

:global(button:disabled) {
opacity: 0.5;
opacity: 0.5 !important;
}

:global(
Expand Down
8 changes: 1 addition & 7 deletions web/src/routes/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
<script lang="ts">
import { author } from '../stores/Author';
import Login from './Login.svelte';
</script>

<svelte:head>
<title>nostter</title>
</svelte:head>

<main>
<h1>nostter</h1>
{#if $author === undefined}
<Login />
{/if}
</main>
<Login />
Loading