SMM-5 Dynamic menu improvements #355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwaclawczyk
force-pushed
the
feature/105318
branch
from
8fe831f to
bb0971f
Compare
|
A lot of linter errors but I guess we cannot fix those in a short timeframe |
kruchy8
reviewed
Jan 28, 2025
| */ | ||
| public function getCategoriesProductCount($categoryIds = []) | ||
| { | ||
| $productTable = $this->getConnection()->getTableName('catalog_category_product'); |
There was a problem hiding this comment.
This may provide misleading data as catalog_category_product table is source of truth for all product category associations including disabled and not visible products. (In Example will indicate category full of disabled products as non-zero products, even thou navigating to that category will yield zero products).
There is table catalog_category_product_index_store<store_id> that contains visibility - can You check if it is depopluated when changing product status? As it may be better source of data if it is indeed not having entries for disabled products.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds support for handling dynamic menus. Discussion started in #317
Menu starting with this pr will piggy back off of the cache invalidation process. Menu can now gather cache tags from nodes' and include it in menu block's cache tags.