Code quality

feat: use local diff when github API call fail #2694

Triggered via pull request July 31, 2023 14:23

m-maillot

opened #984

feat/use-local-git-fallback

Status Success

Total duration 15m 29s

Artifacts –

quality.yml

on: pull_request

Matrix: Lint

Matrix: Test

Annotations

10 errors and 59 warnings

Lint Dockerfile: docker/elasticsearch/Dockerfile#L1

DL3026 error: Use only an allowed registry in the FROM image

Lint Dockerfile: targets/alert-cli/Dockerfile#L4

DL3026 error: Use only an allowed registry in the FROM image

Lint Dockerfile: targets/alert-cli/Dockerfile#L12

DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.

Lint Dockerfile: targets/alert-cli/Dockerfile#L14

DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.

Lint Dockerfile: targets/alert-cli/Dockerfile#L16

DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.

Lint Dockerfile: targets/alert-cli/Dockerfile#L19

DL3026 error: Use only an allowed registry in the FROM image

Lint Dockerfile: targets/alert-cli/Dockerfile#L22

DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`

Lint Dockerfile: targets/contributions/Dockerfile#L3

DL3026 error: Use only an allowed registry in the FROM image

Lint Dockerfile: targets/contributions/Dockerfile#L22

DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.

Lint Dockerfile: targets/contributions/Dockerfile#L24

DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.

Lint Dockerfile

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Build

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Test (@socialgouv/cdtn-logger)

Test (@shared/elasticsearch-document-adapter)

Lint (@socialgouv/cdtn-elasticsearch)

Lint (@shared/dila-resolver)

Lint (@shared/elasticsearch-document-adapter)

Lint (@shared/elasticsearch-document-adapter): shared/elasticsearch-document-adapter/src/__tests__/cdtnDocuments.test.ts#L24

Unsafe argument of type `any` assigned to a parameter of type `{ [s: string]: unknown; } | ArrayLike<unknown>`

Lint (@shared/elasticsearch-document-adapter): shared/elasticsearch-document-adapter/src/__tests__/cdtnDocuments.test.ts#L44

Unsafe argument of type `any` assigned to a parameter of type `{ [s: string]: unknown; } | ArrayLike<unknown>`

Lint (@shared/elasticsearch-document-adapter): shared/elasticsearch-document-adapter/src/__tests__/cdtnDocuments.test.ts#L81

Do not use "@ts-ignore" because it alters compilation errors

Lint (@shared/elasticsearch-document-adapter): shared/elasticsearch-document-adapter/src/breadcrumbs.ts#L6

Use an `interface` instead of a `type`

Lint (@shared/elasticsearch-document-adapter): shared/elasticsearch-document-adapter/src/breadcrumbs.ts#L27

'parentTheme' is already declared in the upper scope on line 26 column 11

Lint (@shared/elasticsearch-document-adapter): shared/elasticsearch-document-adapter/src/breadcrumbs.ts#L65

Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator

Lint (@shared/elasticsearch-document-adapter): shared/elasticsearch-document-adapter/src/cdtnDocuments.ts#L58

Unexpected any. Specify a different type

Lint (@shared/elasticsearch-document-adapter): shared/elasticsearch-document-adapter/src/cdtnDocuments.ts#L59

Unexpected any. Specify a different type

Lint (@shared/elasticsearch-document-adapter): shared/elasticsearch-document-adapter/src/cdtnDocuments.ts#L62

Unexpected any. Specify a different type

Lint (@shared/elasticsearch-document-adapter): shared/elasticsearch-document-adapter/src/cdtnDocuments.ts#L66

Unsafe return of an `any` typed value

Test (@shared/dila-resolver)

Lint (@socialgouv/cdtn-logger)

Lint (@socialgouv/cdtn-logger): shared/logger/src/index.ts#L3

Variable name `Console` must match one of the following formats: camelCase, UPPER_CASE

Lint (export-elasticsearch)

Lint (export-elasticsearch): targets/export-elasticsearch/src/controllers/__test__/export.test.ts#L41

'_next' is defined but never used

Lint (export-elasticsearch): targets/export-elasticsearch/src/controllers/__test__/export.test.ts#L54

Object Literal Property name `created_at` must match one of the following formats: camelCase

Lint (export-elasticsearch): targets/export-elasticsearch/src/controllers/__test__/export.test.ts#L58

Object Literal Property name `updated_at` must match one of the following formats: camelCase

Lint (export-elasticsearch): targets/export-elasticsearch/src/controllers/__test__/export.test.ts#L59

Object Literal Property name `user_id` must match one of the following formats: camelCase

Lint (export-elasticsearch): targets/export-elasticsearch/src/controllers/__test__/export.test.ts#L71

Object Literal Property name `created_at` must match one of the following formats: camelCase

Lint (export-elasticsearch): targets/export-elasticsearch/src/controllers/__test__/export.test.ts#L75

Object Literal Property name `updated_at` must match one of the following formats: camelCase

Lint (export-elasticsearch): targets/export-elasticsearch/src/controllers/__test__/export.test.ts#L76

Object Literal Property name `user_id` must match one of the following formats: camelCase

Lint (export-elasticsearch): targets/export-elasticsearch/src/controllers/__test__/export.test.ts#L90

Object Literal Property name `created_at` must match one of the following formats: camelCase

Lint (export-elasticsearch): targets/export-elasticsearch/src/controllers/__test__/export.test.ts#L94

Object Literal Property name `updated_at` must match one of the following formats: camelCase

Lint (export-elasticsearch): targets/export-elasticsearch/src/controllers/__test__/export.test.ts#L95

Object Literal Property name `user_id` must match one of the following formats: camelCase

Test (export-elasticsearch)

Test (@socialgouv/cdtn-elasticsearch)

Test (ingester)

Lint (alert-cli)

Lint (alert-cli): targets/alert-cli/src/APIs/api.ts#L138

Object Literal Property name `Authorization` must match one of the following formats: camelCase

Lint (alert-cli): targets/alert-cli/src/__tests__/relevantContent.test.ts#L19

Object Literal Property name `dila_cid` must match one of the following formats: camelCase

Lint (alert-cli): targets/alert-cli/src/__tests__/relevantContent.test.ts#L20

Object Literal Property name `dila_container_id` must match one of the following formats: camelCase

Lint (alert-cli): targets/alert-cli/src/__tests__/relevantContent.test.ts#L21

Object Literal Property name `dila_id` must match one of the following formats: camelCase

Lint (alert-cli): targets/alert-cli/src/__tests__/relevantContent.test.ts#L27

Object Literal Property name `dila_cid` must match one of the following formats: camelCase

Lint (alert-cli): targets/alert-cli/src/__tests__/relevantContent.test.ts#L28

Object Literal Property name `dila_container_id` must match one of the following formats: camelCase

Lint (alert-cli): targets/alert-cli/src/__tests__/relevantContent.test.ts#L29

Object Literal Property name `dila_id` must match one of the following formats: camelCase

Lint (alert-cli): targets/alert-cli/src/__tests__/relevantContent.test.ts#L44

Object Literal Property name `dila_cid` must match one of the following formats: camelCase

Lint (alert-cli): targets/alert-cli/src/__tests__/relevantContent.test.ts#L45

Object Literal Property name `dila_container_id` must match one of the following formats: camelCase

Lint (alert-cli): targets/alert-cli/src/__tests__/relevantContent.test.ts#L46

Object Literal Property name `dila_id` must match one of the following formats: camelCase

Test (frontend)

Test (alert-cli)

Lint (frontend)

Lint (ingester)

Lint (ingester): targets/ingester/src/articles/kali/__tests__/indexed-article.test.ts#L25

Async arrow function has no 'await' expression

Lint (ingester): targets/ingester/src/articles/kali/__tests__/load-agreement-articles.specs.ts#L25

Object Literal Property name `agreement_id` must match one of the following formats: camelCase

Lint (ingester): targets/ingester/src/articles/kali/agreement-articles-with-path.ts#L22

Unsafe argument of type `any` assigned to a parameter of type `Node`

Lint (ingester): targets/ingester/src/articles/kali/agreement-articles-with-path.ts#L22

Unexpected any. Specify a different type

Lint (ingester): targets/ingester/src/articles/kali/agreement-articles-with-path.ts#L29

Unsafe return of an `any` typed value

Lint (ingester): targets/ingester/src/articles/kali/load-agreement-articles.ts#L6

Use an `interface` instead of a `type`

Lint (ingester): targets/ingester/src/articles/kali/load-agreement-articles.ts#L9

Type Property name `agreement_id` must match one of the following formats: camelCase

Lint (ingester): targets/ingester/src/articles/kali/load-agreement-articles.ts#L19

Parameter name `agreement_id` must match one of the following formats: camelCase

Lint (ingester): targets/ingester/src/articles/kali/load-agreement-articles.ts#L31

Object Literal Property name `agreement_id` must match one of the following formats: camelCase

Lint (ingester): targets/ingester/src/articles/kali/load-agreement-articles.ts#L40

Parameter name `kali_id` must match one of the following formats: camelCase

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use local diff when github API call fail #2694

Summary