fix(env): set default credentials when .env is not set (#1041)

SocialGouv · Sep 28, 2023 · f545433 · f545433
1 parent 390e646
commit f545433
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 15 deletions.
diff --git a/targets/frontend/src/config.ts b/targets/frontend/src/config.ts
@@ -2,9 +2,7 @@ export const ACCOUNT_MAIL_SENDER = "[email protected]";
 export const JWT_TOKEN_EXPIRES = 15; // 15 min
 export const REFRESH_TOKEN_EXPIRES = 43200; // 30 days in minutes
 export const ACTIVATION_TOKEN_EXPIRES = 10080; // 7 days in minutes
-export const HASURA_GRAPHQL_JWT_SECRET = process.env
-  .HASURA_GRAPHQL_JWT_SECRET ?? {
-  type: "HS256",
-  key: "a_pretty_long_secret_key_that_should_be_at_least_32_char",
-};
+export const HASURA_GRAPHQL_JWT_SECRET =
+  process.env.HASURA_GRAPHQL_JWT_SECRET ??
+  '{"type":"HS256","key":"a_pretty_long_secret_key_that_should_be_at_least_32_char"}';
 export const BASE_URL = process.env.FRONTEND_HOST || `http://localhost:3000`;
diff --git a/targets/frontend/src/lib/azure.js b/targets/frontend/src/lib/azure.js
@@ -5,8 +5,8 @@ import {
 } from "@azure/storage-blob";
 
 const AZURE_STORAGE_ACCOUNT = {
-  key: process.env.AZURE_STORAGE_ACCOUNT_KEY || "",
-  name: process.env.AZURE_STORAGE_ACCOUNT_NAME || "",
+  key: process.env.AZURE_STORAGE_ACCOUNT_KEY || "accountKey",
+  name: process.env.AZURE_STORAGE_ACCOUNT_NAME || "cdtnadmindev",
 };
 
 export const getBlobContainer = (containerName) => {

diff --git a/targets/frontend/src/lib/emails/sendmail.js b/targets/frontend/src/lib/emails/sendmail.js
@@ -3,10 +3,10 @@ import nodemailer from "nodemailer";
 export default function sendmail(mailOptions) {
   const transport = nodemailer.createTransport({
     auth: {
-      pass: process.env.SMTP_EMAIL_PASSWORD,
-      user: process.env.SMTP_EMAIL_USER,
+      pass: process.env.SMTP_EMAIL_PASSWORD ?? "pass",
+      user: process.env.SMTP_EMAIL_USER ?? "email",
     },
-    host: process.env.SMTP_URL,
+    host: process.env.SMTP_URL ?? "smtp.url",
     port: 587,
   });
   return transport.sendMail(mailOptions).finally(() => transport.close());

diff --git a/targets/frontend/src/pages/api/login.js b/targets/frontend/src/pages/api/login.js
@@ -9,9 +9,7 @@ import { getExpiryDate } from "src/lib/duration";
 
 import { loginQuery, refreshTokenMutation } from "./login.gql";
 
-const { REFRESH_TOKEN_EXPIRES = "" } = process.env;
-
-import { JWT_TOKEN_EXPIRES } from "../../config";
+import { JWT_TOKEN_EXPIRES, REFRESH_TOKEN_EXPIRES } from "../../config";
 
 export default async function login(req, res) {
   const apiError = createErrorFor(res);

diff --git a/targets/frontend/src/pages/api/storage/[path].js b/targets/frontend/src/pages/api/storage/[path].js
@@ -4,7 +4,7 @@ import { createErrorFor } from "src/lib/apiError";
 import { deleteBlob } from "src/lib/azure";
 import { HASURA_GRAPHQL_JWT_SECRET } from "../../../config";
 
-const container = process.env.STORAGE_CONTAINER;
+const container = process.env.STORAGE_CONTAINER ?? "cdtn-dev";
 const jwtSecret = JSON.parse(HASURA_GRAPHQL_JWT_SECRET);
 
 export default async function deleteFiles(req, res) {

diff --git a/targets/frontend/src/pages/api/storage/index.js b/targets/frontend/src/pages/api/storage/index.js
@@ -7,7 +7,7 @@ import { isUploadFileSafe } from "src/lib/secu";
 import * as stream from "stream";
 import { HASURA_GRAPHQL_JWT_SECRET } from "../../../config";
 
-const container = process.env.STORAGE_CONTAINER;
+const container = process.env.STORAGE_CONTAINER ?? "cdtn-dev";
 const jwtSecret = JSON.parse(HASURA_GRAPHQL_JWT_SECRET);
 
 async function endPoint(req, res) {