Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ajout du support de l'accordéon sur les contributions #1020

Merged
merged 17 commits into from
Sep 22, 2023
Merged

feat: ajout du support de l'accordéon sur les contributions #1020

merged 17 commits into from
Sep 22, 2023

Conversation

m-maillot
Copy link
Contributor

@m-maillot m-maillot commented Sep 19, 2023 •
edited
Loading

Exemple de contenu généré :

<details class="details">
  <summary>CDI</summary>
  <div data-type="detailsContent"><p>Ceci est un contenu</p></div>
</details>

@socket-security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@tiptap/extension-placeholder 2.1.10 None +0 31.5 kB _bdbch
@tiptap/react 2.0.3...2.1.10 None +4/-88 521 kB _bdbch

🚮 Removed packages: @tiptap/[email protected]

@m-maillot m-maillot requested a review from a team as a code owner September 19, 2023 14:20
@m-maillot m-maillot temporarily deployed to review-auto September 20, 2023 11:17 — with GitHub Actions Inactive
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@m-maillot m-maillot temporarily deployed to review-auto September 21, 2023 09:33 — with GitHub Actions Inactive
@m-maillot m-maillot temporarily deployed to review-auto September 21, 2023 11:34 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

🎉 Deployment for commit 5d1c5dc :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/contributions:sha-5d1c5dc52dd7471ba11e28fe952dea68c569a71b
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/export:sha-5d1c5dc52dd7471ba11e28fe952dea68c569a71b
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/frontend:sha-5d1c5dc52dd7471ba11e28fe952dea68c569a71b
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/hasura:sha-5d1c5dc52dd7471ba11e28fe952dea68c569a71b
Debug

Viczei
Viczei reviewed Sep 22, 2023
View reviewed changes
targets/frontend/src/components/forms/EditionField/Editor.tsx
Comment on lines +121 to +172
.ProseMirror {
> * + * {
margin-top: 0.75em;
}

.is-empty::before {
content: attr(data-placeholder);
float: left;
color: #adb5bd;
pointer-events: none;
height: 0;
}

.details {
display: flex;
margin: 1rem 0;
border: 0;
padding: 0.5rem;

> button {
display: flex;
cursor: pointer;
background: transparent;
border: none;
padding: 0;

&::before {
content: url("data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIyNCIgaGVpZ2h0PSIyNCIgdmlld0JveD0iMCAwIDI0IDI0IiBmaWxsPSJub25lIiBzdHJva2U9ImN1cnJlbnRDb2xvciIgc3Ryb2tlLXdpZHRoPSIyIiBzdHJva2UtbGluZWNhcD0icm91bmQiIHN0cm9rZS1saW5lam9pbj0icm91bmQiIGFyaWEtaGlkZGVuPSJ0cnVlIiBjbGFzcz0ic2MtaW1XWUFJIGpFTHpJTCI+PHBvbHlsaW5lIHBvaW50cz0iOSAxOCAxNSAxMiA5IDYiIHN0cm9rZT0iIzZmOGFjOSI+PC9wb2x5bGluZT48L3N2Zz4=");
display: flex;
justify-content: center;
align-items: center;
color: #6f8ac9;
font-weight: bold;
width: 2.5em;
height: 2em;
}
}

&.is-open > button::before {
content: url("data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIyNCIgaGVpZ2h0PSIyNCIgdmlld0JveD0iMCAwIDI0IDI0IiBmaWxsPSJub25lIiBzdHJva2U9ImN1cnJlbnRDb2xvciIgc3Ryb2tlLXdpZHRoPSIyIiBzdHJva2UtbGluZWNhcD0icm91bmQiIHN0cm9rZS1saW5lam9pbj0icm91bmQiIGFyaWEtaGlkZGVuPSJ0cnVlIiBjbGFzcz0ic2MtaW1XWUFJIGpFTHpJTCI+PHBvbHlsaW5lIHBvaW50cz0iOSAxOCAxNSAxMiA5IDYiIHN0cm9rZT0iIzZmOGFjOSI+PC9wb2x5bGluZT48L3N2Zz4=");
transform: rotate(90deg);
}

> div {
flex: 1 1 auto;
}

:last-child {
margin-bottom: 0;
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On va avoir des conflits ici ^^

maxgfr
maxgfr approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@maxgfr maxgfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes !

targets/export-elasticsearch/Dockerfile
Comment on lines +19 to +20
RUN --mount=type=secret,id=npmrc,target=/.npmrc \
yarn --frozen-lockfile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@m-maillot m-maillot merged commit c55bd4c into master Sep 22, 2023
31 checks passed
@m-maillot m-maillot deleted the feat/add-accordion branch September 22, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viczei Viczei Viczei approved these changes

@carolineBda carolineBda carolineBda approved these changes

@maxgfr maxgfr maxgfr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@m-maillot @Viczei @carolineBda @maxgfr @SocialGroovyBot