fix(contributions): ajout d'un selecteur de references pour les fiches SP #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgfr
requested review from
Viczei,
carolineBda and
m-maillot
and removed request for
Viczei and
carolineBda
maxgfr
had a problem deploying
to
review-auto
GitHub Actions
Failure
maxgfr
had a problem deploying
to
review-auto
GitHub Actions
Failure
maxgfr
had a problem deploying
to
review-auto
GitHub Actions
Failure
m-maillot
reviewed
Sep 26, 2023
targets/frontend/src/components/contributions/answers/answerReferences.ts
Outdated
Show resolved
Hide resolved
targets/frontend/src/components/contributions/answers/answer.query.ts
Outdated
Show resolved
Hide resolved
targets/frontend/src/components/contributions/answers/references/CdtnReferenceInput.tsx
Show resolved
Hide resolved
targets/frontend/src/components/contributions/answers/references/LegiReferenceInput.tsx
Show resolved
Hide resolved
targets/frontend/src/components/contributions/answers/references/ReferenceInput.tsx
Show resolved
Hide resolved
m-maillot
approved these changes
Sep 26, 2023
maxgfr
had a problem deploying
to
review-auto
GitHub Actions
Failure
maxgfr
had a problem deploying
to
review-auto
GitHub Actions
Failure
|
Kudos, SonarCloud Quality Gate passed!
|
carolineBda
approved these changes
Sep 27, 2023
| @@ -62,6 +63,7 @@ export const ContributionsAnswer = ({ | |||
| kaliReferences: [], | |||
| otherReferences: [], | |||
| cdtnReferences: [], | |||
| contentFichesSpDocument: answer?.contentFichesSpDocument ? {} : undefined, | |||
There was a problem hiding this comment.
t'es sur que t'as besoin de faire ça ?
There was a problem hiding this comment.
Oui, malheuresement, on doit initialiser ces valeurs, car urql, ne sait pas si y'a un champ ou non :(
targets/frontend/src/components/contributions/answers/references/cdtnReferencesSearch.query.ts
Show resolved
Hide resolved
Viczei
reviewed
Sep 27, 2023
targets/frontend/src/components/contributions/answers/references/cdtnReferencesSearch.query.ts
Outdated
Show resolved
Hide resolved
Viczei
approved these changes
Sep 27, 2023
maxgfr
had a problem deploying
to
review-auto
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1028