Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(affichage des cc): quand une cc est inconnue sur une entreprise #5284

Merged
merged 5 commits into from
Jul 26, 2023

Conversation

carolineBda
Copy link
Contributor

No description provided.

@@ -23,13 +23,4 @@ describe("Conventions collectives", () => {
"/convention-collective/29-hospitalisation-privee-etablissements-prives-dhospitalisation-de-soins-d"
);
});
it("je vois une 404 si l'iddc n'existe pas", () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ce tests est déjà couvert par le not-found.spec

@carolineBda carolineBda temporarily deployed to review-auto July 20, 2023 18:32 — with GitHub Actions Inactive
@@ -46,8 +46,8 @@ export const SearchEnterpriseInput = ({
searchParams.query,
searchParams.address
);
const [query, setQuery] = useState("");
const [address, setAddress] = useState("");
const [query, setQuery] = useState(searchParams.query);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça c'est le fix de la query quand on fait back

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bien vu !

isWidgetMode={isWidgetMode}
/>
) : (
<DisabledTile
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça c'est pour afficher les CC que l'on ne connait pas

@@ -46,8 +46,8 @@ export const SearchEnterpriseInput = ({
searchParams.query,
searchParams.address
);
const [query, setQuery] = useState("");
const [address, setAddress] = useState("");
const [query, setQuery] = useState(searchParams.query);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bien vu !

@carolineBda carolineBda temporarily deployed to review-auto July 24, 2023 14:00 — with GitHub Actions Inactive
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@carolineBda carolineBda temporarily deployed to review-auto July 24, 2023 14:40 — with GitHub Actions Inactive
num: convention.idcc,
shortTitle: convention.shortTitle,
shortTitle: convention.shortTitle ?? "Convention collective non reconnue",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je mets un titre par défaut dans l'api parce qu'on s'en sert partout notamment dans le cookie

@carolineBda carolineBda merged commit 99aa96c into dev Jul 26, 2023
23 checks passed
@carolineBda carolineBda deleted the carolineBda/search-company branch July 26, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants