feat: 5271 indemnité de licenciement créer un questionnaire spécifique #5287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
added 2 commits
July 25, 2023 17:11
carolineBda
approved these changes
Jul 26, 2023
packages/code-du-travail-frontend/src/outils/common/Feedback/QuestionnaireAdvanced.tsx
Show resolved
Hide resolved
m-maillot
reviewed
Jul 31, 2023
packages/code-du-travail-frontend/src/outils/IndemniteLicenciement/index.tsx
Outdated
Show resolved
Hide resolved
packages/code-du-travail-frontend/src/outils/common/Feedback/QuestionnaireAdvanced.tsx
Outdated
Show resolved
Hide resolved
packages/code-du-travail-frontend/src/outils/common/Feedback/QuestionnaireAdvanced.tsx
Outdated
Show resolved
Hide resolved
packages/code-du-travail-frontend/src/outils/common/Feedback/QuestionnaireAdvanced.tsx
Outdated
Show resolved
Hide resolved
packages/code-du-travail-frontend/src/outils/common/Feedback/QuestionnaireAdvanced.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+45
to
+47
| badEventValue={FEEDBACK_RESULT.NOT_AT_ALL} | ||
| averageEventValue={FEEDBACK_RESULT.AVERAGE} | ||
| goodEventValue={FEEDBACK_RESULT.YES} |
There was a problem hiding this comment.
On ne pourrait pas mettre des valeurs par défaut ici ?
packages/code-du-travail-frontend/src/outils/common/Feedback/QuestionnaireAdvanced.tsx
Outdated
Show resolved
Hide resolved
packages/code-du-travail-frontend/src/outils/common/Feedback/QuestionnaireAdvanced.tsx
Show resolved
Hide resolved
maxgfr
approved these changes
Jul 31, 2023
packages/code-du-travail-frontend/src/outils/IndemniteLicenciement/index.tsx
Outdated
Show resolved
Hide resolved
| </Flex> | ||
| <RelatedItems items={relatedItems} /> | ||
| <Feedback url={router.asPath} /> | ||
| {router.asPath !== "/outils/indemnite-licenciement" && ( |
There was a problem hiding this comment.
peut être faire un array pour éviter d'avoir une url statique dans le code en mode MY_ARRAY.includes(router.asPath)
packages/code-du-travail-frontend/src/outils/common/Feedback/QuestionnaireAdvanced.tsx
Show resolved
Hide resolved
packages/code-du-travail-frontend/src/outils/common/Feedback/__tests__/ui.ts
Outdated
Show resolved
Hide resolved
|
🎉 Deployment for commit d5aa0e5 : IngressesDocker images
Debug
|
…ment/index.tsx Co-authored-by: Martial Maillot <[email protected]>
…uestionnaireAdvanced.tsx Co-authored-by: Martial Maillot <[email protected]>
…uestionnaireAdvanced.tsx Co-authored-by: Martial Maillot <[email protected]>
…uestionnaireAdvanced.tsx Co-authored-by: Martial Maillot <[email protected]>
…uestionnaireAdvanced.tsx Co-authored-by: Martial Maillot <[email protected]>
…uestionnaireAdvanced.tsx Co-authored-by: Martial Maillot <[email protected]>
|
@m-maillot en fait, il n'y avait pas de bug, c'est juste la zone de click de la croix qui est petite. du coup, ce que j'ai fait c'est que je l'ai agrandi |
maxgfr
deleted the
5271-indemnité-de-licenciement-créer-un-questionnaire-spécifique
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.