feat(dsfr): ajout du composant "Avez-vous trouvé une réponse à votre question" #6121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgfr
commented
Sep 12, 2024
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
carolineBda
temporarily deployed
to
review-auto
GitHub Actions
Inactive
carolineBda
requested changes
Sep 16, 2024
packages/code-du-travail-frontend/src/modules/layout/feedback/FeedbackAnswered.tsx
Outdated
Show resolved
Hide resolved
packages/code-du-travail-frontend/src/modules/layout/feedback/FeedbackContent.tsx
Outdated
Show resolved
Hide resolved
packages/code-du-travail-frontend/src/modules/layout/feedback/tracking.ts
Show resolved
Hide resolved
packages/code-du-travail-frontend/src/modules/layout/feedback/tracking.ts
Outdated
Show resolved
Hide resolved
packages/code-du-travail-frontend/src/modules/layout/feedback/tracking.ts
Outdated
Show resolved
Hide resolved
carolineBda
temporarily deployed
to
review-auto
GitHub Actions
Inactive
m-maillot
had a problem deploying
to
review-auto
GitHub Actions
Failure
m-maillot
temporarily deployed
to
review-auto
GitHub Actions
Inactive
maxgfr
changed the title
maxgfr
commented
Sep 16, 2024
packages/code-du-travail-frontend/src/modules/layout/feedback/tracking.ts
Outdated
Show resolved
Hide resolved
Viczei
reviewed
Sep 17, 2024
packages/code-du-travail-frontend/src/modules/layout/feedback/FeedbackContent.tsx
Outdated
Show resolved
Hide resolved
Viczei
approved these changes
Sep 17, 2024
carolineBda
reviewed
Sep 17, 2024
| }; | ||
|
|
||
| const emitNegativeFeedback = () => { | ||
| if (baseUrl) { |
There was a problem hiding this comment.
c'est possible qu'il ne soit pas définit ?
There was a problem hiding this comment.
Non, car il envoie un null via le pathName
carolineBda
reviewed
Sep 17, 2024
|
🎉 Deployment for commit cf0e2b8 : IngressesDocker images
|
* fix: ui * fix: composant
maxgfr
had a problem deploying
to
review-auto
GitHub Actions
Failure
carolineBda
reviewed
Sep 19, 2024
|
|
||
| export const useNeedMoreInfoEvents = () => { | ||
| const emitTrackNumber = () => { | ||
| matopush([ |
There was a problem hiding this comment.
t'as pas utilisé ta méthode sendEvent ?
m-maillot
added a commit
that referenced
this pull request
Oct 15, 2024
* fix: dsfr * fix: dsfr * fix: dsfr * fix: tests * fix: build * fix: build * fix: build * feat(dsfr): ajout du footer (#6079) * feat: add code * fix: tests * fix: tests * fix: tests * fix: tests * fix: tests * fix: dernier titi * fix: autoclick * fix: bug * feat(css): ajout de la lib `panda-css` (zero-runtime) (#6085) * fix: pandacss * fix: build * fix: build * feat(dsfr): ajout de la page stats (#6090) * fix: pandacss * fix: build * fix: build * fix(stats): add page * fix: stats * fix: tests * fix: tests * Update packages/code-du-travail-frontend/src/modules/mentions-legales/index.tsx Co-authored-by: Martial Maillot <[email protected]> * fix(recherche): remonter les pré-qualifiés dans la recherche (#6082) * chore(release): version 4.151.1 * fix(csp): remove reporting on sentry (#6092) * fix: config * fix: config * fix: config * empty * fix: config * empty * Update packages/code-du-travail-frontend/src/modules/mentions-legales/index.tsx Co-authored-by: Martial Maillot <[email protected]> * Update packages/code-du-travail-frontend/src/modules/mentions-legales/index.tsx Co-authored-by: Martial Maillot <[email protected]> * fix: config * chore(dsfr): mise à jour de la version DSFR * fix(dsfr): ignore les exceptions d'hydratation * feat(tests): ajout du module de testing (#6096) * fix: tests * fix: tests * fix: command * fix: merge date * fix: tests * fix: tests * fix: tests * fix: tests * fix(dsfr): ignore les exceptions d'hydratation * fix: readme * feat(DSFR): migration de la page article du code du travail (#6099) * feat: 6093 dsfr page politique de confidentialit (#6094) * feat: implémentation page politique confidentialité dsfr * chore: clean * fix: iframe dark mode * chore: refacto + e2e test * feat: convert a to Link * chore: review * chore: rename test --------- Co-authored-by: victor <[email protected]> * feat(dsfr): ajout des liens d'évitement (#6120) * feat(dsfr): migration de la page plan du site (#6097) * feat(dsfr): mise à jour des snapshots * feat(dsfr): mise à jour des snapshots * chore(dsfr): mise à jour de la lib DSFR * feat(dsfr): ajout du composant "Avez-vous trouvé une réponse à votre question" (#6121) * fix: merge date * fix: satisfaction * fix: retours preavis * fix: retours preavis * fix: tests * move feedback component to the page articleCodeDuTravail.tsx * clean-up css * fix: feedback * fix: feedback * fix: tests * fix: tests * feat(dsfr): création du composant "Besoin de plus d'information" (#6135) * fix: ui * fix: composant --------- Co-authored-by: carolineBda <[email protected]> Co-authored-by: Martial Maillot <[email protected]> * fix: retours * fix: tests * feat: nouvelle API pour les articles du code du travail (#6132) Co-authored-by: carolineBda <[email protected]> * fix(spec) : fix de la spec article-code-du-travail.spec.ts * fix(dsfr): ajout de la config pour supprimer le `insafe-inline` des `scripts` dans les `csp` (#6151) * feat(dsfr): ajout de matomo pour tracker les events (#6157) * fix: matomo * fix: matomo --------- Co-authored-by: Martial Maillot <[email protected]> * fix(feedback): ajout d'une logique de caractères restants (#6156) * fix: tests * feat: limiter à 500 caractères la saisie * feat: limiter à 500 caractères la saisie --------- Co-authored-by: Martial Maillot <[email protected]> * feat(dsfr): ajout du nouveau logo (#6159) * feat(dsfr): ajout des pages d'erreurs (404 + 500) (#6146) * fix: pages * fix: 404 * fix: tests * fix: tests * fix: tests * fix: lint * test error * fix errors * Fix spec * add button to test error page * feat: force error 500 for testing purpose * feat: revert errors --------- Co-authored-by: carolineBda <[email protected]> Co-authored-by: Martial Maillot <[email protected]> * feat: séparation des anciennes API et des nouvelles (#6183) * fix(article code du travail): retrait du tag Code du travail (#6182) * feat(config): correction de `husky`, ajout de `prettier` pour le formattage et de `lint-staged` pour runner le formattage au `precommit` (#6192) * fix: prettier * fix: prettier * fix: readme * fix: readme * fix: bug * fix: prettier * fix: prettier * fix: tests * fix: tests * fix: prettier * fix: prettier * fix: branch * merge dev * fix: crash lors de la sélection d'une suggestion (#6202) * fix: crash lors de la sélection d'une suggestion * Update packages/code-du-travail-frontend/src/modules/utils/events.ts Co-authored-by: Caroline <[email protected]> --------- Co-authored-by: Caroline <[email protected]> * fix: crash lors de la sélection d'une suggestion (#6209) * fix: crash lors de la sélection d'une suggestion * Update packages/code-du-travail-frontend/src/modules/utils/events.ts Co-authored-by: Caroline <[email protected]> --------- Co-authored-by: Martial Maillot <[email protected]> * fix(suggestion): style + move feedback into RichComponent (#6210) * fix: format --------- Co-authored-by: Caroline <[email protected]> Co-authored-by: Martial Maillot <[email protected]> Co-authored-by: Social Groovy Bot <[email protected]> Co-authored-by: Victor Zeinstra <[email protected]> Co-authored-by: victor <[email protected]> Co-authored-by: carolineBda <[email protected]>
Viczei
added a commit
that referenced
this pull request
Oct 22, 2024
* fix: dsfr * fix: dsfr * fix: dsfr * fix: tests * fix: build * fix: build * fix: build * feat(dsfr): ajout du footer (#6079) * feat: add code * fix: tests * fix: tests * fix: tests * fix: tests * fix: tests * fix: dernier titi * fix: autoclick * fix: bug * feat(css): ajout de la lib `panda-css` (zero-runtime) (#6085) * fix: pandacss * fix: build * fix: build * feat(dsfr): ajout de la page stats (#6090) * fix: pandacss * fix: build * fix: build * fix(stats): add page * fix: stats * fix: tests * fix: tests * Update packages/code-du-travail-frontend/src/modules/mentions-legales/index.tsx Co-authored-by: Martial Maillot <[email protected]> * fix(recherche): remonter les pré-qualifiés dans la recherche (#6082) * chore(release): version 4.151.1 * fix(csp): remove reporting on sentry (#6092) * fix: config * fix: config * fix: config * empty * fix: config * empty * Update packages/code-du-travail-frontend/src/modules/mentions-legales/index.tsx Co-authored-by: Martial Maillot <[email protected]> * Update packages/code-du-travail-frontend/src/modules/mentions-legales/index.tsx Co-authored-by: Martial Maillot <[email protected]> * fix: config * chore(dsfr): mise à jour de la version DSFR * fix(dsfr): ignore les exceptions d'hydratation * feat(tests): ajout du module de testing (#6096) * fix: tests * fix: tests * fix: command * fix: merge date * fix: tests * fix: tests * fix: tests * fix: tests * fix(dsfr): ignore les exceptions d'hydratation * fix: readme * feat(DSFR): migration de la page article du code du travail (#6099) * feat: 6093 dsfr page politique de confidentialit (#6094) * feat: implémentation page politique confidentialité dsfr * chore: clean * fix: iframe dark mode * chore: refacto + e2e test * feat: convert a to Link * chore: review * chore: rename test --------- Co-authored-by: victor <[email protected]> * feat(dsfr): ajout des liens d'évitement (#6120) * feat(dsfr): migration de la page plan du site (#6097) * feat(dsfr): mise à jour des snapshots * feat(dsfr): mise à jour des snapshots * chore(dsfr): mise à jour de la lib DSFR * feat(dsfr): ajout du composant "Avez-vous trouvé une réponse à votre question" (#6121) * fix: merge date * fix: satisfaction * fix: retours preavis * fix: retours preavis * fix: tests * move feedback component to the page articleCodeDuTravail.tsx * clean-up css * fix: feedback * fix: feedback * fix: tests * fix: tests * feat(dsfr): création du composant "Besoin de plus d'information" (#6135) * fix: ui * fix: composant --------- Co-authored-by: carolineBda <[email protected]> Co-authored-by: Martial Maillot <[email protected]> * fix: retours * fix: tests * feat: nouvelle API pour les articles du code du travail (#6132) Co-authored-by: carolineBda <[email protected]> * fix(spec) : fix de la spec article-code-du-travail.spec.ts * fix(dsfr): ajout de la config pour supprimer le `insafe-inline` des `scripts` dans les `csp` (#6151) * feat(dsfr): ajout de matomo pour tracker les events (#6157) * fix: matomo * fix: matomo --------- Co-authored-by: Martial Maillot <[email protected]> * fix(feedback): ajout d'une logique de caractères restants (#6156) * fix: tests * feat: limiter à 500 caractères la saisie * feat: limiter à 500 caractères la saisie --------- Co-authored-by: Martial Maillot <[email protected]> * feat(dsfr): ajout du nouveau logo (#6159) * feat(dsfr): ajout des pages d'erreurs (404 + 500) (#6146) * fix: pages * fix: 404 * fix: tests * fix: tests * fix: tests * fix: lint * test error * fix errors * Fix spec * add button to test error page * feat: force error 500 for testing purpose * feat: revert errors --------- Co-authored-by: carolineBda <[email protected]> Co-authored-by: Martial Maillot <[email protected]> * feat: séparation des anciennes API et des nouvelles (#6183) * fix(article code du travail): retrait du tag Code du travail (#6182) * feat(config): correction de `husky`, ajout de `prettier` pour le formattage et de `lint-staged` pour runner le formattage au `precommit` (#6192) * fix: prettier * fix: prettier * fix: readme * fix: readme * fix: bug * fix: prettier * fix: prettier * fix: tests * fix: tests * fix: prettier * fix: prettier * fix: branch * merge dev * feat: implémentation simulateur brut net * chore: fix ts * chore: snap * chore: clean * chore: clean * chore: clean * chore: review * feat: update responsive * Revert "Merge branch 'dev' into simulateur-brut-net-dsfr" This reverts commit 0748928, reversing changes made to cd15bc7. * chore: clean * feat: chore clean * chore: clean * chore: remove undesired files * chore: remove undesired files * chore: clean * fix: meta description share * feat: switch simu brut net couleur par defaut * fix: ts * fix: bug load --------- Co-authored-by: maxgfr <[email protected]> Co-authored-by: Caroline <[email protected]> Co-authored-by: Martial Maillot <[email protected]> Co-authored-by: Social Groovy Bot <[email protected]> Co-authored-by: victor <[email protected]> Co-authored-by: carolineBda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6116
fix #6114