feat(dsfr): ajout d'un detecteur d'adblock pour éviter qu'un usager partage un message dans le vide #6226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-maillot
approved these changes
Oct 22, 2024
| export const FeedbackAdblock = () => { | ||
| return ( | ||
| <> | ||
| <h2 className={fr.cx("fr-h5")}>Un adblock a été détecté.</h2> |
There was a problem hiding this comment.
Changer le terme adblock par bloqueur de publicité.
Peut être revoir le texte pour expliciter le fait que l'on n'affiche pas de pub sur le site.
carolineBda
reviewed
Oct 28, 2024
| export const useDetectAdBlock = () => { | ||
| const [adBlockDetected, setAdBlockDetected] = useState(false); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
top comme méthode 👍
Est-ce que plutôt qu'un useEffect on devrait pas le faire lors du 1er click sur OUI ou NON ?
m-maillot
force-pushed
the
maxgfr/adblock-msg
branch
from
a749173
to
a0461b3
Compare
m-maillot
force-pushed
the
maxgfr/adblock-msg
branch
from
a0461b3
to
7438517
Compare
m-maillot
force-pushed
the
maxgfr/adblock-msg
branch
from
7438517
to
f9db471
Compare
…ovider de pub pour éviter de modifier les CSP (#6227)
m-maillot
force-pushed
the
maxgfr/adblock-msg
branch
from
f9db471
to
5d6be94
Compare
|
🎉 Deployment for commit 5d6be94 : IngressesDocker images
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6201