fix(dsfr): ne pas utiliser deux fois la balise HTML #6246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-maillot
commented
Oct 30, 2024
| <Footer /> | ||
| </body> | ||
| </html> | ||
| <> |
There was a problem hiding this comment.
Le soucis est que l'on utilise la balise HTML et BODY alors qu'elles sont déjà présentes dans le layout de base :
React-dsfr utilise la balise html pour stocker les infos sur le mode en cours (dark / light) pour synchro le client et le serveur. Si tu as 2 HTML, next.js semblent prendre le dernier et écraser l'ancien avec le nouveau (et affiche un warning que l'on avait loupé). Cela ne se produit que lorsque l'on navigue de page en page. Au premier chargement, il semble utiliser la première balise HTML (render server vs client ?).
Du coup, on écrase les valeurs de react-dsfr qui se perd sur le dark mode et génère des erreurs et un comportement étrange.
|
🎉 Deployment for commit 713526c : Docker images
|
carolineBda
approved these changes
Oct 31, 2024
Viczei
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6206