Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt declaration recap for 2020, 2019 and 2018 #1825

Merged

Conversation

jonat75
Copy link
Contributor

@jonat75 jonat75 commented Nov 13, 2023

Closes #1770

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@pom421
Copy link
Contributor

pom421 commented Nov 13, 2023

@jonat75 Si tu as testé sur des données de 2018, 2019 et 2020, je veux bien que tu le mettes dans le premier bloc de cet issue, pour mémoire.

En règle général, j'essaie de donner du détail sur mon analyse, copie d'écran, etc.., qu'on reparte pas de zéro si on revient sur cet issue dans le futur.

@jonat75 jonat75 marked this pull request as draft November 13, 2023 14:41
@jonat75 jonat75 force-pushed the feat/adapt-decla-recap-for-old-years branch from 592cfa0 to 89ce9c4 Compare November 19, 2023 15:49
@jonat75 jonat75 marked this pull request as ready for review November 19, 2023 15:49
Copy link

🎉 Deployment for commit 89ce9c4 :

Ingresses
Docker images
  • 📦 docker pull ghcr.io/socialgouv/docker/nginx:7.0.1
  • 📦 docker pull harbor.fabrique.social.gouv.fr/egapro/egapro/api:sha-89ce9c44eea8678eabb6e8613ea62218383e9783
  • 📦 docker pull harbor.fabrique.social.gouv.fr/egapro/egapro/app:sha-89ce9c44eea8678eabb6e8613ea62218383e9783
  • 📦 docker pull maildev/maildev:2.1.0
  • 📦 docker pull sosedoff/pgweb:0.14.1
Debug

@pom421
Copy link
Contributor

pom421 commented Nov 21, 2023

Testé sur

  • 775685779/2018 : ok
  • 775688450/2019: ok
  • 441725736/2020: ok
  • 814068748/2021: ok

@pom421 pom421 merged commit 5decc37 into persist/migration-fronts Nov 21, 2023
10 checks passed
@pom421 pom421 deleted the feat/adapt-decla-recap-for-old-years branch November 21, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Déclaration V2 : Adapter la page Récap pour les années indicateurs 2018, 2019 et 2020
3 participants