Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug 1777 population favorable #1846

Merged
merged 12 commits into from
Nov 20, 2023
Merged

fix: bug 1777 population favorable #1846

merged 12 commits into from
Nov 20, 2023

Conversation

pom421
Copy link
Contributor

@pom421 pom421 commented Nov 16, 2023 •
edited
Loading

fix #1777

  • utilisation de "" comme valeur par défaut des inputs de formulaire pour les champs résultat et Percentage. (considered to be a good practice by official React doc)
  • refactor des messages d'erreur des formulaires dans un fichier messages.ts, afin d'avoir plus d'homogénéité dans les messages côté UI

@pom421 pom421 self-assigned this Nov 16, 2023
@pom421 pom421 marked this pull request as draft November 16, 2023 11:39
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@pom421 pom421 requested a review from jonat75 November 17, 2023 23:23
@pom421 pom421 marked this pull request as ready for review November 17, 2023 23:23
@github-actions GitHub Actions
Copy link

🎉 Deployment for commit 91c450c :

Ingresses
Docker images
  • 📦 docker pull ghcr.io/socialgouv/docker/nginx:7.0.1
  • 📦 docker pull harbor.fabrique.social.gouv.fr/egapro/egapro/api:sha-91c450cc72cf24fcc1fd59ba878f9b1092bee9f1
  • 📦 docker pull harbor.fabrique.social.gouv.fr/egapro/egapro/app:sha-91c450cc72cf24fcc1fd59ba878f9b1092bee9f1
  • 📦 docker pull maildev/maildev:2.1.0
  • 📦 docker pull sosedoff/pgweb:0.14.1
Debug

@pom421 pom421 merged commit 24b9520 into persist/migration-fronts Nov 20, 2023
10 checks passed
@pom421 pom421 deleted the fix/bug-1177-iteration3 branch November 20, 2023 10:42
@pom421 pom421 linked an issue Nov 27, 2023 that may be closed by this pull request
Déclaration V2 : message d'erreur lorsque le résultat est = 0% écart rému, augmentation, promotion #1835
Open
jonat75 pushed a commit that referenced this pull request Dec 12, 2023
@pom421 @jonat75
fix: bug 1777 population favorable (#1846)
ad8574a
jonat75 pushed a commit that referenced this pull request Dec 12, 2023
@pom421 @jonat75
fix: bug 1777 population favorable (#1846)
0bd5f48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonat75 jonat75 Awaiting requested review from jonat75

Assignees

@pom421 pom421

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Déclaration V2 : message d'erreur lorsque le résultat est = 0% écart rému, augmentation, promotion
2 participants
@pom421 @SocialGroovyBot