Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(patches): allow other hosts as cert-manager hosts #275

Merged
merged 2 commits into from
Apr 10, 2023
Merged

fix(patches): allow other hosts as cert-manager hosts #275

merged 2 commits into from
Apr 10, 2023

Conversation

revolunet
Copy link
Member

@revolunet revolunet commented Apr 7, 2023 •
edited
Loading

Also allow *.beta.gouv.fr hosts to have cert-manager annotations

add some tests

@revolunet revolunet requested review from devthejo and achauve April 7, 2023 09:05
@revolunet revolunet changed the title fix(patches): allow beta.gouv.fr as cert-manager hosts fix(patches): allow other hosts as cert-manager hosts Apr 7, 2023
@revolunet
Copy link
Member Author

En fait je me demande si on devrait pas plutôt ajouter une option useCertManager, à true par défaut et qu'on peut désactiver sur les rares cas où on fournit le certificat. wdyt ?

@devthejo
Copy link
Member

devthejo commented Apr 7, 2023 •
edited
Loading

En fait je me demande si on devrait pas plutôt ajouter une option useCertManager, à true par défaut et qu'on peut désactiver sur les rares cas où on fournit le certificat. wdyt ?

tu peux désactiver la patch, au même niveau que options, tu peux mettre enabled: false, après si tu veux pouvoir optout par ingress on pourrait gérer ça via une annotation du genre kontinuous/use-cert-manager: "false" (une annotation doit forcément être une string)

@devthejo
Copy link
Member

cette PR sur ta PR permet ça ;) :
#276

@revolunet revolunet merged commit fde0ab5 into master Apr 10, 2023
@revolunet revolunet deleted the external-urls-certs branch April 10, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devthejo devthejo devthejo approved these changes

@achauve achauve achauve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@revolunet @devthejo @achauve