hotfix: remove picto / remove drinking water (#507)

SocialGouv · Apr 3, 2024 · eb7b814 · eb7b814
1 parent 8464daf
commit eb7b814
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/api-node/src/aggregators/drinking_water.ts b/api-node/src/aggregators/drinking_water.ts
@@ -16,7 +16,7 @@ import {
   DataAvailabilityEnum,
   IndicatorsSlugEnum,
   type User,
-  Prisma,
+  type Prisma,
 } from '@prisma/client';
 import { sendAlertNotification } from '~/utils/notifications/alert';
 import {
@@ -115,7 +115,7 @@ async function fetchDrinkingWaterData(udi: User['udi']) {
   };
 
   Object.keys(hubeEauLastTestCheckQuery).forEach((key) => {
-    let value =
+    const value =
       hubeEauLastTestCheckQuery[key as keyof typeof hubeEauLastTestCheckQuery];
     if (value) {
       hubEauLastTestCheckURL.searchParams.append(
@@ -180,7 +180,7 @@ async function fetchDrinkingWaterData(udi: User['udi']) {
   };
 
   Object.keys(hubEauQuery).forEach((key) => {
-    let value = hubEauQuery[key as keyof typeof hubEauQuery];
+    const value = hubEauQuery[key as keyof typeof hubEauQuery];
     if (value) {
       hubEauURL.searchParams.append(
         key,
@@ -288,11 +288,12 @@ async function fetchDrinkingWaterData(udi: User['udi']) {
     if (hubeauUdiResponse.next) {
       getHubeauDataRecursive(hubeauUdiResponse.next);
     } else {
-      if (currentPrelevementConclusions && currentPrelevementParametersCount)
+      if (currentPrelevementConclusions && currentPrelevementParametersCount) {
         prelevements.push({
           ...currentPrelevementConclusions,
           parameters_count: currentPrelevementParametersCount,
         });
+      }
     }
   }
 

diff --git a/api-node/src/getters/drinking_water.ts b/api-node/src/getters/drinking_water.ts
@@ -6,7 +6,7 @@ import type { Indicator, IndicatorByPeriod } from '~/types/api/indicator';
 import type { ExtendedShortPrelevementResult } from '~/types/api/drinking_water';
 import {
   IndicatorsSlugEnum,
-  Prisma,
+  type Prisma,
   type Municipality,
   type User,
 } from '@prisma/client';
@@ -82,9 +82,8 @@ async function getDrinkingWaterFromUdi({
           checkPrelevementConformityBacteriological(drinkingWater),
       },
       status: lastPrelevementConformity,
-      recommendations: [
-        drinkingWater.conclusion_conformite_prelevement as string,
-      ],
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+      recommendations: [drinkingWater.conclusion_conformite_prelevement!],
     },
     values: ((drinkingWater.all_tests_results ?? []) as Prisma.JsonArray)?.map(
       (jsonValue) => {

diff --git a/api-node/src/getters/indicators_list.ts b/api-node/src/getters/indicators_list.ts
@@ -37,6 +37,7 @@ const indicatorsObject: Record<IndicatorsSlugEnum, IndicatorItem> = {
     slug: IndicatorsSlugEnum.bathing_water,
   },
   [IndicatorsSlugEnum.drinking_water]: {
+    active: false,
     name: 'Eau du robinet',
     long_name: "La qualité de l'eau du robinet",
     short_name: 'Eau du robinet',