Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(beta): header + footer #1023

Merged
merged 8 commits into from
Aug 3, 2023
Merged

feat(beta): header + footer #1023

merged 8 commits into from
Aug 3, 2023

Conversation

arnaudambro
Copy link
Collaborator

No description provided.

@socket-security
Copy link

socket-security bot commented Aug 3, 2023 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@codegouvfr/react-dsfr 0.73.2 network, filesystem, environment +1 61 MB garronej

🚮 Removed packages: @types/[email protected], [email protected]

@arnaudambro arnaudambro requested a review from a team as a code owner August 3, 2023 13:50
@arnaudambro arnaudambro temporarily deployed to review-auto August 3, 2023 14:25 — with GitHub Actions Inactive
@arnaudambro arnaudambro changed the title feat: header feat(beta): header + footer Aug 3, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@gary-van-woerkens
Copy link
Contributor

Il a une drole de tete le footer :)

image

@gary-van-woerkens gary-van-woerkens temporarily deployed to review-auto August 3, 2023 18:19 — with GitHub Actions Inactive
@gary-van-woerkens gary-van-woerkens temporarily deployed to review-auto August 3, 2023 18:55 — with GitHub Actions Inactive
@gary-van-woerkens gary-van-woerkens temporarily deployed to review-auto August 3, 2023 19:04 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

gary-van-woerkens
gary-van-woerkens approved these changes Aug 3, 2023
View reviewed changes
.github/workflows/tests.yml Show resolved Hide resolved
src/app/components/HeaderAndFooter.tsx Outdated Show resolved Hide resolved
src/app/StartDsfr.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

🎉 Deployment for commit 08ac0ba :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/fabrique/www/app:sha-08ac0babfbc379970bdf7c75c0283c5e1e0841f3
Debug

@gary-van-woerkens gary-van-woerkens linked an issue Aug 3, 2023 that may be closed by this pull request
Setup technique #1009
Closed
7 tasks
@gary-van-woerkens gary-van-woerkens merged commit 9d966a0 into beta Aug 3, 2023
8 checks passed
@gary-van-woerkens gary-van-woerkens deleted the feat/add-dsfr branch August 3, 2023 19:13
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.40.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gary-van-woerkens gary-van-woerkens gary-van-woerkens approved these changes

Assignees

@gary-van-woerkens gary-van-woerkens

Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup technique
3 participants
@arnaudambro @gary-van-woerkens @SocialGroovyBot