[gRPC] 补充搜索子区直播信息定义 #1058
Closed
[gRPC] 补充搜索子区直播信息定义 #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#1054 已经包含了这一改动 |
时间上完美错过 😂，我昨天第一时间试了你提交的proto文件列表，测试后dynamic的module内容缺失，所以回退之后自己解包补全了直播搜索的数据结构。 看了下commit历史，我昨天试的版本是 feat: update grpc protos from [email protected] (generated with helper tool)，现在已经fix了。 你做了很棒的工作，谢谢！ |
因为那个时候我才发现没把 oneof 的 fields 给输出来😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
做了什么
添加了
SearchLiveRoom的定义，并补充Item类型缺失的 live_room 字段。为什么
目前如果用 SearchByType api 搜索直播相关的内容会无法获取，因为直播间列表会以
SearchLiveRoom而不是SearchLiveCard显示。