Skip to content

Fix build oder on open API generation #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Fix build oder on open API generation #298

merged 1 commit into from
Apr 30, 2025

Conversation

bcomnes
Copy link
Member

@bcomnes bcomnes commented Apr 30, 2025

We must prettify before we can generate. Otherwise the the ouput is going to be all crazy.

After this lands, #293 will work again after getting recreated.

We must prettify before we can generate. Otherwise the the ouput is going to be all crazy.
@bcomnes bcomnes requested a review from jdalton April 30, 2025 21:32
@bcomnes
Copy link
Member Author

bcomnes commented Apr 30, 2025

run-p generate-sdk:* && run-p generate-sdk:clean:*"

Will actually run generate-sdk:clean:* twice. If you have an order dependent build, I suggest running one glob in series, and the parallelizable steps as a separate glob.

@jdalton
Copy link
Collaborator

jdalton commented Apr 30, 2025

Thank you @bcomnes!

@jdalton jdalton merged commit a623aa1 into main Apr 30, 2025
15 checks passed
@jdalton jdalton deleted the fix-generate-order branch April 30, 2025 21:43
jdalton pushed a commit that referenced this pull request Apr 30, 2025
We must prettify before we can generate. Otherwise the the ouput is going to be all crazy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants