Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeql CWE 502 #33

Merged
merged 4 commits into from
Nov 15, 2020
Merged

Codeql CWE 502 #33

merged 4 commits into from
Nov 15, 2020

Conversation

Sokom141
Copy link
Owner

Fixes CWE-502
Closes #12

…02 found by CodeQL (unsafe deserialization)

Now only a strict set of objects can be sent through the ObjectInputStream.
…umber of times before giving up the connection to the server.

Now both the Server and the Client can't play before a connection is made.
General improvements to the gameplay and GUI of GameBoard.

Closes #12
@Sokom141 Sokom141 added bug Something isn't working enhancement New feature or request labels Nov 13, 2020
@Sokom141 Sokom141 added this to the 1.0 milestone Nov 13, 2020
@Sokom141 Sokom141 requested a review from kevchi9 November 13, 2020 20:45
@Sokom141 Sokom141 self-assigned this Nov 13, 2020
@Sokom141 Sokom141 linked an issue Nov 13, 2020 that may be closed by this pull request
@Sokom141 Sokom141 merged commit 9feed9f into develop Nov 15, 2020
@Sokom141 Sokom141 deleted the codeql-cwe-502 branch November 15, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the game wait for the server/client connection
2 participants