Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of thread_ts and reply_to_thread in Slack messages #5

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

cyrus2281
Copy link

This pull request fixes an issue where the thread_ts and reply_to_thread values were not being properly handled in Slack messages. The commit "Passing slacks ts and thread_ts as is, and using reply_to_thread and thread_id for cm logic" ensures that the correct values are assigned to the thread_ts and reply_to_thread variables in the code. This resolves the problem of messages not being sent to the correct threads in Slack.

Copy link

gitstream-cm bot commented Oct 17, 2024

Please mark whether you used Copilot to assist coding in this PR

  • Copilot Assisted

Copy link
Collaborator

@efunneko efunneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

@gregmeldrum gregmeldrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cyrus2281 cyrus2281 merged commit ab621a2 into main Oct 17, 2024
2 of 3 checks passed
@cyrus2281 cyrus2281 deleted the cyrus/sessionID branch October 17, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants