Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI-178: Align streaming field naming conventions in the Slack connector with those used in cognitive-mesh #9

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

gregmeldrum
Copy link

What is the purpose of this change?

Align streaming field naming conventions in the Slack connector with those used in cognitive-mesh to maintain consistency across the codebase.

How is this accomplished?

Renamed streaming-related fields in the SlackOutput component:

  • "stream" to "streaming"
  • "first_streamed_chunk" to "first_chunk"
  • "last_streamed_chunk" to "last_chunk"

Anything reviews should focus on/be aware of?

@gregmeldrum gregmeldrum requested a review from a team November 5, 2024 14:26
Copy link

gitstream-cm bot commented Nov 5, 2024

Please mark whether you used Copilot to assist coding in this PR

  • Copilot Assisted

Copy link
Collaborator

@efunneko efunneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@gregmeldrum gregmeldrum merged commit 1b78367 into main Nov 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants