Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/afterDevCon #115

Closed
wants to merge 25 commits into from
Closed

Refactor/afterDevCon #115

wants to merge 25 commits into from

Conversation

rolandlor
Copy link
Contributor

No description provided.

bosi95 and others added 23 commits November 13, 2024 15:44
@bosi95 @Kexort
Develop (#113)
b5062a3 
* Fix user count (#112)

* fix activity calc

* fix recent session activity

* Fix 'already redeemed' message (#114)

* separate talk and spaces activity count

---------

Co-authored-by: Kexort <[email protected]>
@rolandlor
refactor: packages, rework eslint rules
f3c0b6c
@rolandlor
refactor: moving components to their right places
58f3825
@rolandlor
correcting errors
cfc57c3
@rolandlor
refactor: move context
86c9e6c
@rolandlor
error correcting
78d3c3c
@rolandlor
refactor: tesconfig + move constants to its right place
9e1581d
@rolandlor
error correcting
9dae7db
@rolandlor
refactor: typings
847ce60
@rolandlor
error correcting
13faf5b
@rolandlor
refactor: redudant page names
8d14075
@rolandlor
error correcting
0a239bf
@rolandlor
refactor
6f21881
@rolandlor
error correcting
1470b05
@rolandlor
general refactor
da162b7
@rolandlor
styling refactor
2779c12
@rolandlor
styling refactor
adaff28
@rolandlor
error correcting
b80aa18
@rolandlor
correcting dependencies
fb95f56
@rolandlor
linting
6de9d82
@rolandlor
prettier
fb0365d
@rolandlor
deleting data folder
12f1f8b
@rolandlor
error correcting
850e30f
bosi95
bosi95 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@bosi95 bosi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. One note: remove page suffix from StayUpdatedPage and ContentFilterPage

bosi95
bosi95 requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@bosi95 bosi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure that only one lock file is present, that is the pnpm.lock. Otherwise build fails

@aranyia
Copy link

aranyia commented Dec 5, 2024

@rolandlor Please point the PR to the develop branch instead of main, so it can go through the QA process on the test environment first.

@rolandlor rolandlor changed the base branch from main to develop December 6, 2024 15:48
@rolandlor rolandlor closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosi95 bosi95 bosi95 requested changes

@Kexort Kexort Awaiting requested review from Kexort

@ottpeter ottpeter Awaiting requested review from ottpeter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolandlor @aranyia @bosi95