Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Feature/style changes #63

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

SharonStrats
Copy link

@SharonStrats SharonStrats commented Mar 5, 2022

This PR does 2 things

  1. change Buttons to use solid-ui buttons
  2. make small style changes
  3. Modified dev standalone to work after the auth refactor

Left to be done:

  1. Make new address book button (need to find where to change it)
    In order to make this change will need to modify solid-ui.login.newAppInstance. could pass in an option in to use the solid-ui button instead to allow for a generic button or a solid-ui button style. I was thinking we could use a 'Secondary' button for contrast.
    See this PR in solid-ui https://github.com/solid/solid-ui/pull/478
  2. there is a little box that shows, when you click a contact or something to edit this is where it sits. look to hide it until used. - this comes from registrationControl I'm not so sure we could change this easily without having an effect on other things. Maybe best to leave it for now.
  3. check to make sure it looks good within SolidOS and if others like it
  4. Could add a little search icon in the Search Input field.

So far...

![Screen Shot 2022-03-05 at 5 24 04 pm](https://user-images.githubusercontent.com/9412507/156871217-be78a84a-d6c4-4f71-bfc4-98
Screen Shot 2022-03-05 at 5 24 24 pm
b16639cc68.png)
Screen Shot 2022-03-05 at 5 26 19 pm

@timea-solid
Copy link
Member

timea-solid commented Mar 7, 2022

😍
I like it!
Change to use solid-ui buttons, great!
Why is the 'make new address book' button left behind style-wise?
I also tested locally and it works.

@timbl
Copy link
Contributor

timbl commented Mar 7, 2022

That's a lot brighter than before. Mainly little things:

  • The "All" button has in fact several colors. Default, I am loading all the groups, I have loaded all the groups, I am displaying all the groups, I have loaded all the groups but not displaying all of them.
  • The All button expand when you click o it and then is stuck big

Agree would be good have a search icon in the search bar. Although its a filter bar in fact -- it only whittles down the contacts you already have displayed.

  • If you put a 🔍 in the left of search bar, then maybe also a little x on the right when I type any text, so I can delete what I have typed.
  • I think "Tools" and "Make a new address book" should be emphasized - grey not purple
  • Icons for "New group" "new person" "New individual" could of course all be made up from green plus and icon for the class in question, which we have in our existing icons.
    • Can we make the search box 100% width

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants