Merge pull request #553 from SolidOS/styleStreamline

Style streamline
SolidOS · Dec 4, 2023 · 26d24f4 · 26d24f4
2 parents f40cba9 + 9860a9c
commit 26d24f4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/tabs.ts b/src/tabs.ts
@@ -182,7 +182,7 @@ export function tabWidget (options: TabWidgetOptions) {
   const rootElement: TabWidgetElement = dom.createElement('div') // 20200117a
 
   rootElement.setAttribute('style', style.tabsRootElement)
-  rootElement.style.flexDirection = (vertical ? 'row' : 'column') + (flipped ? '-reverse;' : ';')
+  rootElement.style.flexDirection = (vertical ? 'row' : 'column') + (flipped ? '-reverse' : '')
 
   const navElement = rootElement.appendChild(dom.createElement('nav'))
   navElement.setAttribute('style', style.tabsNavElement)

diff --git a/test/unit/tabs.test.ts b/test/unit/tabs.test.ts
@@ -178,22 +178,22 @@ describe('tabWidget', () => {
     })
     it('positions tabs on top by default', () => {
       tabWidgetElement = tabs.tabWidget(minimalOptions)
-      expect(tabWidgetElement.style['flex-direction']).toEqual('column;')
+      expect(tabWidgetElement.style['flex-direction']).toEqual('column')
     })
 
     it('can position tabs on right', () => {
       tabWidgetElement = tabs.tabWidget({ orientation: '1', ...minimalOptions })
-      expect(tabWidgetElement.style['flex-direction']).toEqual('row;')
+      expect(tabWidgetElement.style['flex-direction']).toEqual('row')
     })
 
     it('can position tabs on bottom', () => {
       tabWidgetElement = tabs.tabWidget({ orientation: '2', ...minimalOptions })
-      expect(tabWidgetElement.style['flex-direction']).toEqual('column-reverse;')
+      expect(tabWidgetElement.style['flex-direction']).toEqual('column-reverse')
     })
 
     it('can position tabs on left', () => {
       tabWidgetElement = tabs.tabWidget({ orientation: '3', ...minimalOptions })
-      expect(tabWidgetElement.style['flex-direction']).toEqual('row-reverse;')
+      expect(tabWidgetElement.style['flex-direction']).toEqual('row-reverse')
     })
   })