MojangAPI and textures #102

aakatz3 · 2021-03-17T20:47:04Z

It would be super nice to have a way to interact with Mojang's web api; and it would also be nice ot have some utility methods for textures

BOTH are in one pr because they interact with each other a bunch, especially in testing

build.gradle

bukkit/src/main/java/com/dumbdogdiner/stickyapi/bukkit/command/BukkitCommandBuilder.java

common/src/main/java/com/dumbdogdiner/stickyapi/annotation/Broken.java

kokumaji · 2021-03-18T13:08:11Z

webapi/src/main/java/com/dumbdogdiner/stickyapi/webapi/mcapi/Ping.java

+ */
+package com.dumbdogdiner.stickyapi.webapi.mcapi;
+
+class Ping {


one class for just two vars? please move these to wherever they are used, thanks!

Very much agree with koda here - what's this used for? Likely for ping status yes, but imo this is slightly overkill.

kokumaji · 2021-03-18T13:10:42Z

webapi/src/main/java/com/dumbdogdiner/stickyapi/webapi/namemc/Profile.java

+ */
+package com.dumbdogdiner.stickyapi.webapi.namemc;
+
+class Profile {


please remove empty classes

kokumaji · 2021-03-18T13:10:47Z

webapi/src/main/java/com/dumbdogdiner/stickyapi/webapi/namemc/Server.java

+ */
+package com.dumbdogdiner.stickyapi.webapi.namemc;
+
+class Server {


please remove empty classes

aakatz3 · 2021-03-18T16:37:31Z

Re review of irrelevant bits: currently working on pulling these out

codecov · 2021-03-21T17:42:22Z

Codecov Report

Merging #102 (fa22fff) into master (262edf1) will increase coverage by 0.09%.
The diff coverage is 36.99%.

❗ Current head fa22fff differs from pull request most recent head 46dbdc0. Consider uploading reports for the commit 46dbdc0 to get more accurate results

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   34.72%   34.82%   +0.09%     
==========================================
  Files          63       83      +20     
  Lines        2534     3024     +490     
  Branches      286      332      +46     
==========================================
+ Hits          880     1053     +173     
- Misses       1591     1890     +299     
- Partials       63       81      +18

Impacted Files	Coverage Δ
...diner/stickyapi/bukkit/item/PlayerHeadBuilder.java	`0.00% <0.00%> (ø)`
...iner/stickyapi/webapi/minecraftheads/Category.java	`0.00% <0.00%> (ø)`
...iner/stickyapi/webapi/minecraftheads/HeadInfo.java	`0.00% <0.00%> (ø)`
...r/stickyapi/util/http/HttpConnectionException.java	`0.00% <0.00%> (ø)`
...umbdogdiner/stickyapi/util/http/HttpException.java	`0.00% <0.00%> (ø)`
...diner/stickyapi/util/http/HttpStatusException.java	`0.00% <0.00%> (ø)`
...ogdiner/stickyapi/webapi/misc/BlacklistChecks.java	`0.00% <0.00%> (ø)`
...m/dumbdogdiner/stickyapi/webapi/namemc/NameMC.java	`0.00% <0.00%> (ø)`
...gdiner/stickyapi/webapi/namemc/ScrapedProfile.java	`0.00% <0.00%> (ø)`
.../util/textures/headdatabase/MinecraftHeadsAPI.java	`18.75% <18.75%> (ø)`
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262edf1...46dbdc0. Read the comment docs.

aakatz3 · 2021-03-22T22:24:56Z

TODO: add caching support to MojangAPI so it can cache things that are just used, maybe even just a 60 second cache, but it helps if a few things are needed at once

kaylendog

Looks okay - some formatting complaints. Lots of empty classes/seemingly redundant code - are these needed?

kaylendog · 2021-03-23T19:52:04Z

build.gradle

@@ -2,6 +2,10 @@ plugins {
    id "io.freefair.lombok" version "5.3.0" apply false
    id "com.github.hierynomus.license" version "0.15.0" apply false

+    // root project - intellij
+
+    id 'idea'


What is up with all this spacing lul

kaylendog · 2021-03-23T19:52:12Z

build.gradle

@@ -10,6 +14,8 @@ allprojects {
    group = "com.dumbdogdiner"
    version = "2.2.0"

+    apply plugin: "idea"
+


Suggested change

kaylendog · 2021-03-23T19:52:48Z

build.gradle

-    javadoc.options.encoding = "UTF-8"
+    tasks.withType(Javadoc) {
+        options.addBooleanOption("quiet", true)
+        options.encoding = "UTF-8"


This doesn't need to be specified if it's in allprojects {}, no?

kaylendog · 2021-03-23T19:53:13Z

common/build.gradle

@@ -28,6 +28,7 @@ dependencies {
    These is also an accompanying test at (test src) com.dumbdogdiner.stickyapi.StickyAPITest
 */

+


Suggested change

kaylendog · 2021-03-23T19:54:31Z

common/src/main/java/com/dumbdogdiner/stickyapi/annotation/DoNotCall.java

+ * Do not call a method annotated with this, it will do bad things
+ */
+@Documented
+public @interface DoNotCall {


Why does this existtttt

Check where it's used

Point still stands? This isn't really something we need

I think its needed because if any of the methods are called, it will crash, so its for documentation, and can be used with google's errorprone (or that can be used) to make sure they are not called

Okay, but please don't add things unrelated to a PR without asking the rest of the team - for future reference.

Would also like to add that if you dont want a specific method to be called, please use the correct modifier for your use case instead of creating annotations that wont prevent the user from executing this method.

I may be able to do stuff via refactor though

Cloned from previous PR:

Would prefer it if we can write things in a way where methods that are strictly internal can't be called externally.

So yes, would be nice if you can refactor this in a way that doesn't cause this issue.

kaylendog · 2021-03-23T20:18:58Z

webapi/src/main/java/com/dumbdogdiner/stickyapi/webapi/mojang/AshconResponse.java

+ */
+
+
+class AshconResponse {


Internal classes in here are lacking javadoc!

Why do internal data classes need javadoc?

Because we still need to read this code when we're adding to it.

Why do internal data classes need javadoc?

We still need to understand and read the code.

kaylendog · 2021-03-23T20:19:19Z

webapi/src/main/java/com/dumbdogdiner/stickyapi/webapi/mojang/MojangAPI.java

+
+
+// Double check the occurances of this and whatnot, try to fix, etc.
+public class MojangAPI {


Description of class would be nice :3 + javadoc for methods

kaylendog · 2021-03-23T20:20:19Z

webapi/src/main/java/com/dumbdogdiner/stickyapi/webapi/mojang/MojangAPI.java

+    private static final @NotNull OkHttpClient CLIENT = HttpUtil.getDefaultClientInstance();
+
+
+    protected static final @NotNull HttpUrl COMBINED_API_URL = new HttpUrl.Builder()


Would using strings be easier?

Do you mean using .parse? I'm changing to that. HttpUrl is useful for setting flags

Did you end up changing to .parse?

kaylendog · 2021-03-23T20:21:30Z

webapi/src/main/java/com/dumbdogdiner/stickyapi/webapi/namemc/NameMC.java

+import java.util.UUID;
+import java.util.stream.Collectors;
+
+public class NameMC {


See comments for MojangAPI

kaylendog · 2021-03-23T20:22:03Z

webapi/src/main/java/com/dumbdogdiner/stickyapi/webapi/namemc/ScrapedProfile.java

+import java.util.List;
+import java.util.UUID;
+
+class ScrapedProfile {


aakatz3 · 2021-03-23T20:58:29Z

Empty classes will either be filled to spec or removed prior to merging. Have to check for duplicate code, I did my best but haven't checked changelog

kaylendog · 2021-04-19T19:54:43Z

I have no idea what comments from the review I made earlier are valid here, but worth checking some of those. If I get some time tomorrow I will review this too.

aakatz3 · 2021-04-20T15:32:19Z

@SkyezerFox This is the PR that needs review, the other one is for reference only, and is a very old version of the code

kaylendog · 2021-04-20T15:33:38Z

Am knows, hence my comment yesterday.

kaylendog

Some things still valid from the previous PR:

Formatting, but we can fix that with spotless so don't worry.
Pls see comments for a couple of specific things - there are still some unresolved comments above!
thx for working so hard <3

friendly neighborhood floofball

kaylendog · 2021-04-20T16:02:36Z

heads/src/test/java/com/dumbdogdiner/stickyapi/mockedplugin/StickyAPIPlugin.java

+
+import java.io.File;
+
+public class StickyAPIPlugin extends JavaPlugin {


Cloned from the previous review:

Did we ever agree on how we would implement this? Thought for quite a long time it makes much more sense to just pass plugin-specific data about. Do correct me if I'm wrong.

I don't remember us agreeing, and I also don't remember an easy way to do testing on plugin type functions without making a mocked plugin. please correct me

Okay, can you refactor this out into a separate branch and then we can discuss how it would be implemented from there? Would be highly appreciated <3

Its needed for testing heads, I can refactor but it's a pain due to testing. @Prouser123 thoughts?

kaylendog · 2021-04-20T16:03:57Z

textures/build.gradle

+
+    implementation("com.squareup.okhttp3:okhttp")
+    implementation("com.squareup.okhttp3:logging-interceptor")
+    implementation 'commons-validator:commons-validator:1.7'


Cloned from previous PR:

CommonsValidator also allows us to remove a bunch of the luhn/shortid code we have; I can write a URL regex if necessary.

https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_\+.~#?&//=]*) here's one :3

Would be very appreciated if you can stick with Preconditions since we can technically use it.

I wrote a special one, and it should be in there, not sure if pushed. Included domain checking

kaylendog · 2021-04-20T16:04:48Z

webapi/src/main/java/com/dumbdogdiner/stickyapi/webapi/misc/BlacklistChecks.java

+import java.time.Instant;
+
+@UtilityClass
+public class BlacklistChecks {


JavaDoc pls <3

For the entire class :3

kaylendog · 2021-04-20T16:05:46Z

webapi/src/main/java/com/dumbdogdiner/stickyapi/webapi/mojang/MojangAPI.java

+
+    /**
+     * Provides the UUID associated with a given username at a given time.
+     * FIXME: This is currently broken, with an <a href="https://bugs.mojang.com/browse/WEB-3367>open bug report at Mojang</a>


Looks like JavaDoc might complain about this.

Suggested change

* FIXME: This is currently broken, with an <a href="https://bugs.mojang.com/browse/WEB-3367>open bug report at Mojang</a>

* FIXME: This is currently broken, with an <a href="https://bugs.mojang.com/browse/WEB-3367">open bug report at Mojang</a>

Looks broken on my end still. Not included in commit perhaps?

I'm just marking them off as I go so I'm not a dumbwoof

Because I've been asked to make less commits

Who told you that? Many commits are fine as long as you label them properly :3

kaylendog · 2021-04-20T16:08:02Z

common/src/main/java/com/dumbdogdiner/stickyapi/annotation/DoNotCall.java

+ * Do not call a method annotated with this, it will do bad things
+ */
+@Documented
+public @interface DoNotCall {


Cloned from previous PR:

Would prefer it if we can write things in a way where methods that are strictly internal can't be called externally.

So yes, would be nice if you can refactor this in a way that doesn't cause this issue.

kaylendog · 2021-04-20T16:08:44Z

gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.3-bin.zip


From previous PR:

For future reference: please don't change Gradle versions without asking one of us!

kaylendog · 2021-04-20T16:09:40Z

heads/src/main/java/com/dumbdogdiner/stickyapi/bukkit/item/PlayerHeadBuilder.java

+    @DoNotCall
+    @Override
+    @Deprecated
+    public @NotNull SkullBuilder texture(@NotNull String str) {


See comments on DoNotCall.

kaylendog · 2021-04-20T16:12:59Z

...s/src/main/java/com/dumbdogdiner/stickyapi/util/textures/headdatabase/MinecraftHeadsAPI.java

+    public static String getName(int headId) {
+        if(usePlugin)
+            return getNamePlugin(headId);
+        else {


Unnecessary else statement - return breaks out of the method anyway.

kaylendog · 2021-04-20T16:20:52Z

In regards to your comment here, #56 (comment), that's not the code style we're using. Here's Google's styleguide - must draw attention to the section on immutable variables:

If any of the instance's observable state can change, it is not a constant. Merely intending to never mutate the object is not enough.

Given that this is a HashMap and we're not using Collections.unmodifiableMap here (might be worth doing?), this should be in standard lowerCamelCase. Regardless, think we're going to stick with CONSTANT_CASE for constants anyways.

kaylendog · 2021-04-20T16:21:55Z

Formatting complaints can be ignored for now - will be fixed when we get spotless working.

aakatz3 · 2021-04-21T18:02:20Z

@SkyezerFox so, i cant use C style for statics?

kaylendog · 2021-04-21T19:27:38Z

@SkyezerFox so, i cant use C style for statics?

It's not specified in the code style we're planning to use, so I wouldn't do it here while we wait to implement it, no.

aakatz3 · 2021-04-27T18:58:37Z

@SkyezerFox so, i cant use C style for statics?

It's not specified in the code style we're planning to use, so I wouldn't do it here while we wait to implement it, no.

Can we discuss adding it to our styleguide? It's nice to identify statics

kaylendog · 2021-04-27T19:12:26Z

@SkyezerFox so, i cant use C style for statics?

It's not specified in the code style we're planning to use, so I wouldn't do it here while we wait to implement it, no.

Can we discuss adding it to our styleguide? It's nice to identify statics

We can add it to the next meeting, but pls stick with no C statics until we decide.

ZachyFoxx · 2021-06-09T05:07:49Z

My god the build process... Anyway, building fails and there are current conflicts. Please resolve these and await the re-requested reviews.

Note to reviewers: When the above requested changes are completed, you will have 7 days to review before this gets merged.

kokumaji · 2021-06-09T05:29:16Z

Only thing I'd like to add (not going to review in detail), but knowing you, there definitely are bits in this PR that are entirely unrelated to MojangAPI and a thing to get heads. If not done already, I'd ask you to remove them from this PR and open a new one with a proper description of what you want changed (although please don't do this now <3)

kaylendog

Mostly good, still a bunch of comments left over from my March review + added some more - pls fix :3

kaylendog · 2021-06-09T09:05:39Z

heads/src/main/java/com/dumbdogdiner/stickyapi/bukkit/item/PlayerHeadBuilder.java

+        meta = (SkullMeta) head.getItemMeta();
+        Preconditions.checkNotNull(meta, "Player head must have metadata attached");
+        // We check this almost immediately after, so it's OK if it's null temporarily
+        //noinspection ConstantConditions


Can u b careful not to leave editor specific comments around?

kaylendog · 2021-06-09T09:05:55Z

heads/src/main/java/com/dumbdogdiner/stickyapi/bukkit/item/PlayerHeadBuilder.java

+    /**
+     * @param playerId the UUID of the player whose head should be generated
+     */
+    public PlayerHeadBuilder(@NotNull UUID playerId) {


kaylendog · 2021-06-09T09:06:13Z

heads/src/main/java/com/dumbdogdiner/stickyapi/bukkit/item/SkullBuilder.java

+    @Getter
+    @NotNull
+    @VisibleForTesting
+    private String category = "*";


kaylendog · 2021-06-09T09:07:22Z

heads/src/main/java/com/dumbdogdiner/stickyapi/bukkit/item/SkullBuilder.java

+
+        profile.setProperty(new ProfileProperty("textures", texture));
+        meta.setPlayerProfile(profile);
+        @NotNull ItemStack head = new ItemStack(Material.PLAYER_HEAD, quantity);


No need for @NotNull annotations in code - unless you want to add them, kotlin can't do anything useful with them since they're not externally visible.

Its more for reading and notes, and also because when you auto add them it adds them everywhere

kaylendog · 2021-06-09T09:08:48Z

textures/build.gradle

@@ -0,0 +1,75 @@
+plugins {


Definitely a need for a consistent quoting/brackets commit here. Are we doing implementation thing or implementation(thing), "" or ''?

Ideally, if @Prouser123 agrees, it will be kotlin style syntax. When you cut and paste from different things, you get different syntax.

kaylendog · 2021-06-09T09:10:41Z

...s/src/main/java/com/dumbdogdiner/stickyapi/util/textures/headdatabase/MinecraftHeadsAPI.java

+    private static final HeadDatabaseAPI mcheads;
+
+    static {
+        //noinspection ConstantConditions


kaylendog · 2021-06-09T09:11:17Z

...s/src/main/java/com/dumbdogdiner/stickyapi/util/textures/headdatabase/MinecraftHeadsAPI.java

+        //noinspection ConstantConditions
+        if(ServerVersion.isBukkit() && Bukkit.getServer() != null) {
+            if (Bukkit.getPluginManager().getPlugin("HeadDatabase") == null) {
+                Bukkit.getLogger().severe("HeadDatabase Plugin was not found!");


Definitely some logic simplifying possible here - you set them null if none of these conditions match?

If we don't have the heads database plugin availible (either because its not installed or because we arent on bukkit) then it goes to fallback

kaylendog · 2021-06-09T09:12:39Z

textures/src/test/java/com/dumbdogdiner/stickyapi/MinecraftHeadsAPITest.java

+
+        for (int i = 0; i < TEST_REPS; i++) {
+            HeadThing thing;
+            //noinspection StatementWithEmptyBody


kaylendog · 2021-06-09T09:13:18Z

webapi/src/main/java/com/dumbdogdiner/stickyapi/util/http/UrlValidator.java

+        this(DEFAULT_DOMAIN_REGEX);
+    }
+
+    private UrlValidator(Pattern domain){


Yes, this is a private method, but for future devs can you comment on what it does?

kaylendog · 2021-06-09T09:13:56Z

webapi/src/main/java/com/dumbdogdiner/stickyapi/webapi/misc/BlacklistChecks.java

+import java.time.Instant;
+
+@UtilityClass
+public class BlacklistChecks {


For the entire class :3

kaylendog · 2021-06-09T09:18:31Z

An additional comment - why is the config package completely empty now?

kaylendog · 2021-06-09T09:21:46Z

Might b worth cherry-picking stuff since this PR is chonky af.

kaylendog

Note on MojangAPI

kaylendog · 2021-06-09T09:26:36Z

webapi/src/main/java/com/dumbdogdiner/stickyapi/webapi/mojang/MojangAPI.java

+    private static final @NotNull OkHttpClient CLIENT = HttpUtil.getDefaultClientInstance();
+
+
+    protected static final @NotNull HttpUrl COMBINED_API_URL = new HttpUrl.Builder()


Did you end up changing to .parse?

aakatz3 · 2021-06-09T16:27:49Z

Note on MojangAPI

Changing what to .parse?

aakatz3 requested a review from a team as a code owner March 17, 2021 20:47

kokumaji requested changes Mar 18, 2021

View reviewed changes

aakatz3 added 5 commits March 18, 2021 10:47

Add browseJavadoc, allow frames support

9547b85

update gradle

722e392

Fix javadoc issue

394a6cb

Generate javadoc for private

98123df

Lots of heads work

8f9a805

aakatz3 force-pushed the feat/aakatz3/mojangapi branch from 05c3e57 to 8f9a805 Compare March 21, 2021 04:54

aakatz3 added 2 commits March 21, 2021 11:27

Fix things so it works

b62ec95

Fix tests of non-ascii names

81f6708

aakatz3 added 2 commits March 21, 2021 11:54

mini refactor

387ffa4

i forgot to commit

f16ab7d

kaylendog requested changes Mar 23, 2021

View reviewed changes

API fixes

31c3c1d

jcxldn added this to the v3.0 (next) milestone Mar 29, 2021

jcxldn changed the base branch from feat/jcx/major/modules-def to master March 29, 2021 12:04

kaylendog requested changes Apr 20, 2021

View reviewed changes

typo: eu instead of us

e4c188f

Address a bunch (but not all) of the comments

c9d3396

fix test

0e0bc23

comment out mockbukkit and hope

afa7b30

ZachyFoxx requested review from kaylendog and kokumaji June 9, 2021 05:02

kokumaji removed their request for review June 9, 2021 05:30

kaylendog requested changes Jun 9, 2021

View reviewed changes

kaylendog reviewed Jun 9, 2021

View reviewed changes

aakatz3 added 2 commits June 9, 2021 10:41

Allow uploading of failed build information

fa22fff

Merge branch 'master' into feat/aakatz3/mojangapi

bc947a5

aakatz3 force-pushed the feat/aakatz3/mojangapi branch from dd42e0c to bc947a5 Compare June 9, 2021 17:51

Try to fix gradle issues

46dbdc0

		@@ -28,6 +28,7 @@ dependencies {
		These is also an accompanying test at (test src) com.dumbdogdiner.stickyapi.StickyAPITest
		*/



		// Double check the occurances of this and whatnot, try to fix, etc.
		public class MojangAPI {

		private static final @NotNull OkHttpClient CLIENT = HttpUtil.getDefaultClientInstance();


		protected static final @NotNull HttpUrl COMBINED_API_URL = new HttpUrl.Builder()


		import java.io.File;

		public class StickyAPIPlugin extends JavaPlugin {

	* FIXME: This is currently broken, with an <a href="https://bugs.mojang.com/browse/WEB-3367>open bug report at Mojang</a>
	* FIXME: This is currently broken, with an <a href="https://bugs.mojang.com/browse/WEB-3367">open bug report at Mojang</a>

MojangAPI and textures #102

Are you sure you want to change the base?

MojangAPI and textures #102

Conversation

aakatz3 commented Mar 17, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aakatz3 commented Mar 18, 2021

codecov bot commented Mar 21, 2021 • edited Loading

Codecov Report

aakatz3 commented Mar 22, 2021

kaylendog left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaylendog Mar 23, 2021 • edited Loading

Choose a reason for hiding this comment

aakatz3 Mar 24, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aakatz3 commented Mar 23, 2021

kaylendog commented Apr 19, 2021 • edited Loading

aakatz3 commented Apr 20, 2021

kaylendog commented Apr 20, 2021

kaylendog left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaylendog commented Apr 20, 2021 • edited Loading

kaylendog commented Apr 20, 2021

aakatz3 commented Apr 21, 2021

kaylendog commented Apr 21, 2021

aakatz3 commented Apr 27, 2021

kaylendog commented Apr 27, 2021

ZachyFoxx commented Jun 9, 2021

kokumaji commented Jun 9, 2021

kaylendog left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 21, 2021 •

edited

Loading

kaylendog Mar 23, 2021 •

edited

Loading

aakatz3 Mar 24, 2021 •

edited

Loading

kaylendog commented Apr 19, 2021 •

edited

Loading

kaylendog left a comment •

edited

Loading

kaylendog commented Apr 20, 2021 •

edited

Loading