Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to YamlProvider and Locale/LocaleProvider #144

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aakatz3
Copy link
Collaborator

@aakatz3 aakatz3 commented Jun 1, 2021

No description provided.

@aakatz3 aakatz3 requested a review from jcxldn June 1, 2021 19:10
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #144 (bfc11d6) into master (262edf1) will increase coverage by 0.08%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   34.72%   34.80%   +0.08%     
==========================================
  Files          63       63              
  Lines        2534     2551      +17     
  Branches      286      290       +4     
==========================================
+ Hits          880      888       +8     
- Misses       1591     1599       +8     
- Partials       63       64       +1     
Impacted Files Coverage Δ
...stickyapi/bukkit/command/BukkitCommandBuilder.java 0.00% <ø> (ø)
...tickyapi/common/config/providers/YamlProvider.java 75.51% <40.00%> (-24.49%) ⬇️
...r/stickyapi/common/translation/LocaleProvider.java 92.18% <100.00%> (+1.56%) ⬆️
...iner/stickyapi/common/translation/Translation.java 36.84% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262edf1...bfc11d6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant