[REFERENCE ONLY DO NOT REVIEW!!!] Implement Mojang WebAPI, common user root class, and playerheads #56

aakatz3 · 2020-12-20T20:52:26Z

Closes #51

aakatz3 · 2020-12-20T20:53:20Z

Still todo: figure out tests

Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.8.92 to 4.8.98. - [Release notes](https://github.com/classgraph/classgraph/releases) - [Commits](classgraph/classgraph@classgraph-4.8.92...classgraph-4.8.98) Signed-off-by: dependabot-preview[bot] <[email protected]>

codecov · 2020-12-25T20:00:13Z

Codecov Report

Merging #56 (7f2cab7) into master (a6e96d8) will increase coverage by 6.22%.
The diff coverage is 31.74%.

@@             Coverage Diff              @@
##             master      #56      +/-   ##
============================================
+ Coverage     20.39%   26.61%   +6.22%     
- Complexity      111      196      +85     
============================================
  Files            63       76      +13     
  Lines          2859     3179     +320     
  Branches        381      409      +28     
============================================
+ Hits            583      846     +263     
- Misses         2261     2278      +17     
- Partials         15       55      +40

Impacted Files	Coverage Δ	Complexity Δ
...ogdiner/stickyapi/bukkit/command/AsyncCommand.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...stickyapi/bukkit/command/BukkitCommandBuilder.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...umbdogdiner/stickyapi/bukkit/command/ExitCode.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...gdiner/stickyapi/bukkit/command/PluginCommand.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...iner/stickyapi/bukkit/generator/VoidGenerator.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...mbdogdiner/stickyapi/bukkit/gui/ClickableSlot.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...ava/com/dumbdogdiner/stickyapi/bukkit/gui/GUI.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...diner/stickyapi/bukkit/item/PlayerHeadBuilder.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...iner/stickyapi/bukkit/particle/ParticleSystem.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...diner/stickyapi/bukkit/particle/shapes/Circle.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e96d8...7f2cab7. Read the comment docs.

ZachyFoxx · 2020-12-25T21:54:06Z

src/main/java/com/dumbdogdiner/stickyapi/bukkit/user/StickyUserBukkit.java

+
+import java.util.UUID;
+
+public class StickyUserBukkit extends StickyUser {


I thought we decided not to do this?

We definitely decided not to do this.

ZachyFoxx · 2020-12-25T21:54:40Z

src/main/java/com/dumbdogdiner/stickyapi/bungeecord/user/StickyUserBungee.java

+
+import java.util.UUID;
+
+public class StickyUserBungee extends StickyUser {


See above again

ZachyFoxx · 2020-12-25T21:54:47Z

src/main/java/com/dumbdogdiner/stickyapi/common/user/StickyUser.java

+
+import java.util.UUID;
+
+public class StickyUser implements Cacheable {


ZachyFoxx · 2020-12-25T21:55:54Z

src/main/java/com/dumbdogdiner/stickyapi/common/util/textures/MiniBlock.java

@@ -0,0 +1,173 @@
+/*


Oh my... Is this used for heads?

Move to resources please.

If this is moved to resources please remove this class.

ZachyFoxx · 2020-12-25T21:57:30Z

src/main/java/com/dumbdogdiner/stickyapi/common/webapis/AshconResponse.java

+ * Copyright (c) 2020 DumbDogDiner <dumbdogdiner.com>. All rights reserved.
+ * Licensed under the MIT license, see LICENSE for more information...
+ */
+package com.dumbdogdiner.stickyapi.common.webapis;


com.dumbdogdiner.stickyapi.common.webapis to com.dumbdogdiner.stickyapi.common.mojang

The thought was other apis, such as optifine capes or labymod capes, or any other web apis, can be put in here. I will make it com.dumbdogdiner.stickyapi.common.webapi.mojang unless thats too long

com.dumbdogdiner.stickyapi.common.web.mojang

ZachyFoxx · 2020-12-25T21:58:36Z

src/test/java/com/dumbdogdiner/stickyapi/common/util/textures/MobHeadTest.java

+
+
+


Don't add empty files please.

src/main/java/com/dumbdogdiner/stickyapi/common/util/StringUtil.java

ZachyFoxx · 2020-12-25T22:02:36Z

src/main/java/com/dumbdogdiner/stickyapi/common/util/textures/DefaultSkins.java

+
+import lombok.Getter;
+
+public enum DefaultSkins {


Move to resources please.

What format should these be in in resources? SQLite DB??

ZachyFoxx · 2020-12-25T22:02:57Z

src/main/java/com/dumbdogdiner/stickyapi/common/util/textures/MobHead.java

+import com.dumbdogdiner.stickyapi.common.util.StringUtil;
+import lombok.Getter;
+
+public enum MobHead {


Move to resources.

ZachyFoxx · 2020-12-25T22:06:31Z

src/main/java/com/dumbdogdiner/stickyapi/common/webapis/MojangUser.java

+import java.time.Instant;
+import java.util.*;
+
+public class MojangUser extends StickyUser {


Instead of using StickyUser, just make this its own object with the basic user information we'd need, such as username, uuid, skin textures, etc. Pretty much an object for the response from Mojang's API.

kaylendog · 2020-12-20T21:03:58Z

src/main/java/com/dumbdogdiner/stickyapi/bukkit/item/generator/MobHeadGenerator.java

+
+import java.util.UUID;
+
+public class MobHeadGenerator {


MobHeadBuilder?

src/main/java/com/dumbdogdiner/stickyapi/bukkit/item/generator/PlayerHeadGenerator.java

src/main/java/com/dumbdogdiner/stickyapi/common/util/textures/DefaultSkins.java

kaylendog · 2020-12-20T21:07:07Z

src/main/java/com/dumbdogdiner/stickyapi/common/webapis/MojangAPI.java

+     * API URLs
+     */
+
+    public enum APIStatus{


inb4 vlad complains about the lack of a space.

inb4 vlad complains about the lack of a space.

you know me too well <3

build.gradle

kaylendog · 2020-12-25T22:30:15Z

src/main/java/com/dumbdogdiner/stickyapi/common/webapis/MojangUser.java

+
+    public Map<String, List<Instant>> getUsernameHistory(){
+        HashMap<String, List<Instant>> usernameHistory = new HashMap<>();
+        for (AshconResponse.Username u : apiResponse.username_history) {


Consider calling this variable previous or prev?

kaylendog · 2020-12-25T22:30:42Z

src/main/java/com/dumbdogdiner/stickyapi/common/webapis/MojangUser.java

+            if(usernameHistory.containsKey(u.username) && u.changed_at != null){
+                usernameHistory.get(u.username).add(Instant.parse(u.changed_at));
+            } else {
+                ArrayList<Instant> hist = new ArrayList<>();


Suggested change

ArrayList<Instant> hist = new ArrayList<>();

ArrayList<Instant> history = new ArrayList<>();

kaylendog · 2020-12-25T22:30:54Z

src/main/java/com/dumbdogdiner/stickyapi/common/webapis/package-info.java

+/**
+ * This package contains code that is used for obtaining information from Mojang's web API or cached versions. Other APIs may be supported in the future.
+ */
+package com.dumbdogdiner.stickyapi.common.webapis;


Suggested change

package com.dumbdogdiner.stickyapi.common.webapis;

package com.dumbdogdiner.stickyapi.common.webapis;

src/test/java/com/dumbdogdiner/stickyapi/bukkit/item/generator/MobHeadGeneratorTest.java

kaylendog · 2020-12-25T22:31:36Z

src/test/java/com/dumbdogdiner/stickyapi/common/webapis/MojangAPITest.java

+    void getUsername() {
+        assertEquals(new CachedMojangAPI(UUID.fromString("9b6d27b3-f53b-49d1-b8c4-fa807f7575e9")).getUsername(), "Rodwuff");
+    }
+}


Suggested change

}

}

…i-users

kaylendog

Dun worry about the formatting comments - I'm just nitpicking. Those will be fixed by themselves once we merge in #58.

kaylendog · 2020-12-26T12:28:43Z

build.gradle

    implementation 'org.jetbrains:annotations:20.1.0'
    implementation 'com.google.code.gson:gson:2.8.6'
    implementation 'io.github.classgraph:classgraph:4.8.92'
    implementation 'com.github.seancfoley:ipaddress:5.3.3'
+    implementation 'com.squareup.okhttp3:okhttp:4.9.0'
+    implementation 'commons-validator:commons-validator:1.7'


Please use Guava's preconditions rather than shading in deps to StickyAPI.

Please explain

See the JavaDocs for preconditions. This is included in both bukkit and bungee so will work at runtime. No need to shade in extra dependencies.

Unless you're intending to use this for a completely different reason.

Validator is used primarily to check url formatting for validity, and determine if a URL is validly formatted (and I think it also checks if it's resolvable). There are a couple other ways I plan to use it.

We can also theoretically call the minimize() function to reduce jar size

Validator is used primarily to check url formatting for validity, and determine if a URL is validly formatted (and I think it also checks if it's resolvable). There are a couple other ways I plan to use it.

Google preconditions does thissssss - just include a URL regex.

We can also theoretically call the minimize() function to reduce jar size

This has side effects, we've already tried it.

Do we even need to validate the URL ourselves? OkHttp should throw an exception when unable to parse a URL, and if we don't want to use OkHttp, a regular expression will do for URL validity

We could also probably test URL validity by attempting to construct a URL object using the string and seeing if a MalformedURLException is thrown

kaylendog · 2020-12-26T12:29:05Z

gradle.properties

@@ -0,0 +1 @@
+systemProp.file.encoding=utf-8


Suggested change

systemProp.file.encoding=utf-8

systemProp.file.encoding=utf-8

kaylendog · 2020-12-26T12:31:41Z

src/test/java/com/dumbdogdiner/stickyapi/common/util/textures/DefaultSkinsTest.java

+        TestsCommon.superficialEnumCodeCoverage(DefaultSkins.class);
+    }
+
+}


Suggested change

}

}

kaylendog · 2020-12-26T12:31:47Z

src/test/java/com/dumbdogdiner/stickyapi/common/util/textures/MiniBlockTest.java

+    void testEnum(){
+        TestsCommon.superficialEnumCodeCoverage(MiniBlock.class);
+    }
+}


Suggested change

}

}

kaylendog · 2020-12-26T12:31:56Z

src/test/java/com/dumbdogdiner/stickyapi/common/util/textures/MobHeadTest.java

+    public void testHead(){
+        TestsCommon.superficialEnumCodeCoverage(MobHead.class);
+    }
+}


Suggested change

}

}

aakatz3 · 2020-12-27T15:38:44Z

I believe it's used in a couple other places too. I can try looking for another HTTP client, but I really like the way this one works.

…

On Sat, Dec 26, 2020, 9:16 AM skyezer ✨ ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In build.gradle <#56 (comment)>: > implementation 'org.jetbrains:annotations:20.1.0' implementation 'com.google.code.gson:gson:2.8.6' implementation 'io.github.classgraph:classgraph:4.8.92' implementation 'com.github.seancfoley:ipaddress:5.3.3' + implementation 'com.squareup.okhttp3:okhttp:4.9.0' + implementation 'commons-validator:commons-validator:1.7' Unless you're intending to use this for a completely different reason. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#56 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFUCWTJDUQ3O62O46FUB5TSWYD6XANCNFSM4VDLY7BQ> .

src/test/java/com/dumbdogdiner/stickyapi/common/webapis/CachedMojangAPITest.java

…sgraph-classgraph-4.8.98' into feat/heads-mojangapi-users

ZachyFoxx · 2021-01-09T04:41:37Z

build.gradle

+    testImplementation("org.mockito:mockito-core:3.7.0")
+    testImplementation 'com.github.seeseemelk:MockBukkit-v1.16:0.5.0'
+    testImplementation 'it.unimi.dsi:fastutil:8.4.4'


Can we start adding comments for depends so we know why they're added so I don't have to ask like this later...

ZachyFoxx · 2021-01-09T04:41:57Z

build.gradle

 test {
 	useJUnitPlatform()
 	testLogging {
 		events "passed", "skipped", "failed"
        // Show System.out for code ran by tests
        showStandardStreams = true
 	}
+    //ignoreFailures = true


remove this line if it's commented.

Its there for testing. I will try to fold into a new task

ZachyFoxx · 2021-01-09T04:43:42Z

src/main/java/com/dumbdogdiner/stickyapi/StickyAPI.java

+    public static InputStream getResourceAsStream(String resourceName){
+        return StickyAPI.class.getResourceAsStream(resourceName);
+    }


Why? Also, where are the annotations?

ZachyFoxx · 2021-01-09T04:46:03Z

src/main/java/com/dumbdogdiner/stickyapi/bukkit/item/generator/PlayerHeadBuilder.java

+import java.util.Objects;
+import java.util.UUID;
+
+public class PlayerHeadBuilder extends SkullBuilder {


JAVADOC!!!!

Click me

ZachyFoxx · 2021-01-09T04:48:24Z

src/main/java/com/dumbdogdiner/stickyapi/bukkit/item/generator/SkullBuilder.java

+
+    }
+
+    public @NotNull SkullBuilder filter(@NotNull String group) {


See javadoc guidelines

ZachyFoxx · 2021-01-09T04:59:03Z

src/main/java/com/dumbdogdiner/stickyapi/common/util/url/URLUtil.java

@@ -64,7 +64,7 @@ public static TextComponent convertURLs(@NotNull String text) {

                TextComponent urlComponent = new TextComponent(url.getShortened() + " ");
                urlComponent.setClickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, url.getFullPath()));
-                urlComponent.setHoverEvent(new HoverEvent(HoverEvent.Action.SHOW_TEXT, new Text("§7Click to open URL"), new Text("\n§8" + url.getFullPath())));
+                urlComponent.setHoverEvent(new HoverEvent(HoverEvent.Action.SHOW_TEXT, new Text(ChatColor.COLOR_CHAR + "" + ChatColor.GRAY + "Click to open URL"), new Text("\n§8" + url.getFullPath())));


ChatColor.COLOR_CHAR + "" is unnecessary if you have ChatColor.GRAY ahead of it.

ZachyFoxx · 2021-01-09T04:59:17Z

src/main/java/com/dumbdogdiner/stickyapi/common/webapis/AshconResponse.java

+ * Copyright (c) 2020 DumbDogDiner <dumbdogdiner.com>. All rights reserved.
+ * Licensed under the MIT license, see LICENSE for more information...
+ */
+package com.dumbdogdiner.stickyapi.common.webapis;


ZachyFoxx · 2021-01-09T05:01:11Z

src/main/java/com/dumbdogdiner/stickyapi/common/webapis/MojangAPI.java

+
+//TODO: Better error handeling in case of 404
+
+public class MojangAPI {


ZachyFoxx · 2021-01-09T05:01:34Z

src/main/java/com/dumbdogdiner/stickyapi/common/webapis/MojangUser.java

+import java.time.Instant;
+import java.util.*;
+
+public class MojangUser extends StickyUser {


ZachyFoxx · 2021-01-09T05:01:38Z

src/main/java/com/dumbdogdiner/stickyapi/common/webapis/MojangUser.java

+import java.time.Instant;
+import java.util.*;
+
+public class MojangUser extends StickyUser {


ZachyFoxx · 2021-01-09T05:09:14Z

Note i did that review on no sleep, i'll do another one later.

aakatz3 · 2021-01-09T16:30:02Z

Resolves #62

jcxldn · 2021-01-10T18:37:21Z

build.gradle

+tasks.delombok.shouldRunAfter(sources)
+tasks.publish.dependsOn build
+tasks.build.shouldRunAfter(clean)
+tasks.javadoc.shouldRunAfter(clean)


I'm a little hesitant to have javadoc and build run after clean...

@NotZachery thoughts?

I don't see how this could become an issue so I'm fine by it.

They are set to run after as should, not forced. This prevents (if you did, say, ./gradlew build clean javadoc it from building then deleting the build.

Ah okay - thanks!

…-mojangapi-users

ZachyFoxx

TL;DR

No wildcard imports, new line at end of files, and formatting.

ZachyFoxx · 2021-03-22T17:46:43Z

src/main/java/com/dumbdogdiner/stickyapi/annotation/DoNotCall.java

+ * Do not call a method annotated with this, it will do bad things
+ */
+@Documented
+public @interface DoNotCall {


What is the point of this exactly? If a method shouldn't be called why does it exist.

Would prefer it if we can write things in a way where methods that are strictly internal can't be called externally.

ZachyFoxx · 2021-03-22T17:47:03Z

src/main/java/com/dumbdogdiner/stickyapi/bukkit/command/BukkitCommandBuilder.java

-import org.bukkit.command.CommandMap;
-import org.bukkit.command.CommandSender;
-import org.bukkit.command.TabCompleter;
+import org.bukkit.command.*;


No wild card imports.

ZachyFoxx · 2021-03-22T17:51:47Z

src/main/java/com/dumbdogdiner/stickyapi/bukkit/item/PlayerHeadBuilder.java

+    public @NotNull SkullBuilder category(@NotNull String str) {
+        throw new UnsupportedOperationException();
+    }
+}


Suggested change

}

}

ZachyFoxx · 2021-03-22T17:52:17Z

src/main/java/com/dumbdogdiner/stickyapi/bukkit/item/SkullBuilder.java

+        category(qn[0]);
+        return head(qn[1]);
+    }
+}


Suggested change

}

}

ZachyFoxx · 2021-03-22T17:56:11Z

src/main/java/com/dumbdogdiner/stickyapi/bungeecord/command/BungeeCommandBuilder.java

+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+
+import java.util.*;


no wildcard imports

ZachyFoxx · 2021-03-22T18:52:17Z

src/main/java/com/dumbdogdiner/stickyapi/common/arguments/Arguments.java

 import lombok.Getter;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;

+import java.sql.Timestamp;
+import java.util.*;


no wildcard imports

ZachyFoxx · 2021-03-22T18:53:59Z

src/main/java/com/dumbdogdiner/stickyapi/common/translation/LocaleProvider.java

+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+
+import java.io.*;


no wildcard imports

ZachyFoxx · 2021-03-22T18:55:48Z

src/main/java/com/dumbdogdiner/stickyapi/common/util/StringUtil.java

-import java.util.HashMap;
-import java.util.Map;
-import java.util.UUID;
+import java.util.*;


no wildcard imports

ZachyFoxx · 2021-03-22T18:57:02Z

src/main/java/com/dumbdogdiner/stickyapi/common/util/textures/TextureHelper.java

+import java.io.InputStreamReader;
+import java.lang.reflect.Type;
+import java.net.URL;
+import java.util.*;


no wildcard imports

ZachyFoxx · 2021-03-22T18:59:55Z

src/main/java/com/dumbdogdiner/stickyapi/common/util/textures/TextureHelper.java

+        if (splits[0].equals("*")) {
+            @Nullable String texture = null;
+            for (@NotNull String cat : getCategories()) {
+                try {
+                    texture = getTexture(cat, qualifiedName);
+                } catch (NoSuchElementException e) {
+                    continue;
+                }
+                return texture;
+            }
+            return texture;
+        } else {
+            return getTexture(splits[0], splits[1]);
+        }


Suggested change

if (splits[0].equals("*")) {

@Nullable String texture = null;

for (@NotNull String cat : getCategories()) {

try {

texture = getTexture(cat, qualifiedName);

} catch (NoSuchElementException e) {

continue;

}

return texture;

}

return texture;

} else {

return getTexture(splits[0], splits[1]);

}

if (!splits[0].equals("*"))

return getTexture(splits[0], splits[1]);

@Nullable String texture = null;

for (@NotNull String cat : getCategories()) {

try {

texture = getTexture(cat, qualifiedName);

} catch (NoSuchElementException e) {

continue;

}

return texture;

}

return texture;

kaylendog

A couple of things:

Formatting, but we can fix that with spotless so don't worry.
No need to worry about @Nullable and @NotNull annotations in actual method bodies - they're only needed on method signatures so the KLS can work out what is going on.
Need to discuss splitting this into 3 PRs, one for the Web API, the user class, and player heads.
Pls see comments for a couple of specific things.
thx for working so hard <3

friendly neighborhood floofball

kaylendog · 2021-04-19T19:19:46Z

gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.2-bin.zip


For future reference: please don't change Gradle versions without asking one of us!

kaylendog · 2021-04-19T19:20:31Z

src/main/java/com/dumbdogdiner/stickyapi/annotation/DoNotCall.java

+ * Do not call a method annotated with this, it will do bad things
+ */
+@Documented
+public @interface DoNotCall {


Would prefer it if we can write things in a way where methods that are strictly internal can't be called externally.

kaylendog · 2021-04-19T19:21:33Z

src/main/java/com/dumbdogdiner/stickyapi/bukkit/command/AsyncCommand.java

@@ -43,7 +43,7 @@
     * @param commandName The name of the command the user will execute
     * @param owner       The plugin that owns this command.
     */
-    public AsyncCommand(String commandName, Plugin owner) {
+    public AsyncCommand(@NotNull String commandName, Plugin owner) {


For future reference: please keep changes unrelated to the branch somewhere else!

kaylendog · 2021-04-19T19:22:28Z

src/main/java/com/dumbdogdiner/stickyapi/bukkit/command/AsyncCommand.java

        if (args == null)
            throw new NullPointerException("arguments to tabComplete cannot be null");

-        List<String> completions = null;
+        @org.jetbrains.annotations.Nullable List<String> completions = null;


I believe these annotations are for the KLS to help infer things properly - don't think we need them in internal Java code.

kaylendog · 2021-04-19T19:22:54Z

src/main/java/com/dumbdogdiner/stickyapi/bukkit/command/AsyncCommand.java

@@ -181,16 +181,16 @@ public void setTabCompleter(TabCompleter completer) {
     */
    @Override
    public java.util.@NotNull List<String> tabComplete(@NotNull CommandSender sender, @NotNull String alias,
-            String[] args) throws CommandException, IllegalArgumentException {
+            String @org.jetbrains.annotations.Nullable [] args) throws CommandException, IllegalArgumentException {


Wacky import? If this can be imported as normal, would be appreciated.

kaylendog · 2021-04-19T19:37:02Z

src/main/java/com/dumbdogdiner/stickyapi/common/util/textures/TextureHelper.java

+    static final OkHttpClient httpClient = new OkHttpClient();
+    private static final Gson GSON = new Gson();
+    private static final Yaml YAML = new Yaml();
+    private static Map<String, Map<String, String>> TextureMap = generateTextureMap();


Skeeball really doesn't like C-style variable names - do you use this to identify static vars?

Suggested change

private static Map<String, Map<String, String>> TextureMap = generateTextureMap();

private static Map<String, Map<String, String>> textureMap = generateTextureMap();

Global variables are in C-style (title case), caml case is local, all caps is constant - CS106a code style

Also trying to avoid this: https://youtu.be/GPWah4wbwYs?t=1264

kaylendog · 2021-04-19T19:40:02Z

src/main/java/com/dumbdogdiner/stickyapi/common/webapis/HttpException.java

+
+import java.net.URL;
+
+public class HttpException extends RuntimeException {


Believe I've commented on this before - why the need for two layers of wrapping?

It's one layer of wrapping in most cases, but its using inheritance to subclass different types of exception so you can do different behaviors

kaylendog · 2021-04-19T19:40:52Z

src/main/java/com/dumbdogdiner/stickyapi/common/webapis/mojang/OldAPI.java

+
+//TODO: Better error handeling in case of 404
+
+public class OldAPI {


What's this for?

kaylendog · 2021-04-19T19:41:23Z

src/test/java/com/dumbdogdiner/stickyapi/common/util/StringUtilTest.java

-import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.*;


Wildcard import!

kaylendog · 2021-04-19T19:42:03Z

src/test/java/com/dumbdogdiner/stickyapi/common/webapis/MojangAPITest.java

+
+import static org.junit.jupiter.api.Assertions.*;
+
+class MojangAPITest {


Unit test for this would be lovely <3

aakatz3 added 2 commits December 17, 2020 15:03

Initial work on heads (cherrypick + new!)

5972a00

Beta of the mojang api stuff

b8a5bf6

aakatz3 requested review from spazzylemons, jcxldn, ZachyFoxx and kaylendog December 20, 2020 20:52

aakatz3 added this to the next (v2.0) milestone Dec 20, 2020

aakatz3 added feature New feature or request non-breaking labels Dec 20, 2020

aakatz3 self-assigned this Dec 20, 2020

aakatz3 marked this pull request as ready for review December 25, 2020 19:39

Merge branch 'master' into feat/heads-mojangapi-users

7d74d10

ZachyFoxx requested changes Dec 25, 2020

View reviewed changes

kaylendog requested changes Dec 25, 2020

View reviewed changes

aakatz3 added 2 commits December 25, 2020 16:23

Merge remote-tracking branch 'origin/master' into feat/heads-mojangap…

3db73ff

…i-users

Fixed the stupidity of textures as enums and wrote some fun stuff

004fbf0

aakatz3 force-pushed the feat/heads-mojangapi-users branch from 5cb2f06 to 9722bf7 Compare December 26, 2020 07:25

force gradle to uff-8

b014f6b

aakatz3 force-pushed the feat/heads-mojangapi-users branch from 9722bf7 to b014f6b Compare December 26, 2020 07:29

Test the enums so coverage isnt mad

329515f

aakatz3 force-pushed the feat/heads-mojangapi-users branch from 17dfcfc to 329515f Compare December 26, 2020 07:38

kaylendog requested changes Dec 26, 2020

View reviewed changes

ZachyFoxx reviewed Dec 28, 2020

View reviewed changes

src/test/java/com/dumbdogdiner/stickyapi/common/webapis/CachedMojangAPITest.java Show resolved Hide resolved

aakatz3 added 3 commits December 28, 2020 13:35

more api work before changing pc

ab69d97

More tests, use MHF, Start skullbuilder refactor

67a9c4b

Allow generating frames for javadoc

680655b

Merge remote-tracking branch 'origin/dependabot/gradle/io.github.clas…

84c0b3b

…sgraph-classgraph-4.8.98' into feat/heads-mojangapi-users

aakatz3 requested a review from ZachyFoxx January 9, 2021 03:53

ZachyFoxx requested changes Jan 9, 2021

View reviewed changes

aakatz3 mentioned this pull request Jan 9, 2021

‘javadoc’ task fails on master #62

Closed

ZachyFoxx linked an issue Jan 9, 2021 that may be closed by this pull request

‘javadoc’ task fails on master #62

Closed

Add mocked bukkit stuff, remove extra old enums

6b4316f

jcxldn reviewed Jan 10, 2021

View reviewed changes

kokumaji and others added 4 commits January 11, 2021 17:17

PlayerSelector & better math util

42b1739

Merge remote-tracking branch 'origin/yeen-cherrypick' into feat/heads…

d16c439

…-mojangapi-users

Add lots of javadoc

3aaa25b

Infer Nullity

6fc4385

jcxldn force-pushed the master branch from f071af9 to 5e944ef Compare January 16, 2021 21:05

aakatz3 added 7 commits January 16, 2021 14:59

Prepare for new tests, add docs

263164b

Bug fixups

26c8415

javadoc 1

614816b

Merge master

e6a97e1

Fix licence after merge

94683c6

Change how textures are implemented to a json we generate

aa23150

Cleanup

7f2cab7

jcxldn added the (on-hold): blocked label Feb 28, 2021

ZachyFoxx requested review from kaylendog and ZachyFoxx March 20, 2021 18:23

ZachyFoxx requested changes Mar 22, 2021

View reviewed changes

ZachyFoxx marked this pull request as draft March 23, 2021 17:47

kaylendog requested changes Apr 19, 2021

View reviewed changes

aakatz3 changed the title ~~Implement Mojang WebAPI, common user root class, and playerheads~~ [REFERENCE ONLY DO NOT REVIEW!!!] Implement Mojang WebAPI, common user root class, and playerheads Apr 20, 2021

SolteraGG locked and limited conversation to collaborators Apr 20, 2021

kaylendog removed the request for review from spazzylemons April 20, 2021 15:48


		import java.util.UUID;

		public class StickyUserBukkit extends StickyUser {


		import java.util.UUID;

		public class StickyUserBungee extends StickyUser {


		import java.util.UUID;

		public class StickyUser implements Cacheable {

	ArrayList<Instant> hist = new ArrayList<>();
	ArrayList<Instant> history = new ArrayList<>();

	package com.dumbdogdiner.stickyapi.common.webapis;
	package com.dumbdogdiner.stickyapi.common.webapis;

	systemProp.file.encoding=utf-8
	systemProp.file.encoding=utf-8


		}

		public @NotNull SkullBuilder filter(@NotNull String group) {


		//TODO: Better error handeling in case of 404

		public class MojangAPI {

	private static Map<String, Map<String, String>> TextureMap = generateTextureMap();
	private static Map<String, Map<String, String>> textureMap = generateTextureMap();


		import java.net.URL;

		public class HttpException extends RuntimeException {


		//TODO: Better error handeling in case of 404

		public class OldAPI {


		import static org.junit.jupiter.api.Assertions.*;

		class MojangAPITest {

[REFERENCE ONLY DO NOT REVIEW!!!] Implement Mojang WebAPI, common user root class, and playerheads #56

Are you sure you want to change the base?

[REFERENCE ONLY DO NOT REVIEW!!!] Implement Mojang WebAPI, common user root class, and playerheads #56

Conversation

aakatz3 commented Dec 20, 2020 • edited Loading

aakatz3 commented Dec 20, 2020

codecov bot commented Dec 25, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZachyFoxx Dec 25, 2020 • edited by kaylendog Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaylendog left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aakatz3 commented Dec 27, 2020 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZachyFoxx commented Jan 9, 2021

aakatz3 commented Jan 9, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZachyFoxx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aakatz3 commented Dec 20, 2020 •

edited

Loading

codecov bot commented Dec 25, 2020 •

edited

Loading

ZachyFoxx Dec 25, 2020 •

edited by kaylendog

Loading