Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old failing tests #157

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix old failing tests #157

merged 2 commits into from
Jan 9, 2025

Conversation

anxodio
Copy link
Contributor

@anxodio anxodio commented Jan 8, 2025

Description

There are test failing, this PR fixes them (and skips one because i'm not sure how to fix it and it's not failing in prod)

Copy link

github-actions bot commented Jan 8, 2025

Test Results

245 tests   242 ✅  19s ⏱️
  2 suites    3 💤
  2 files      0 ❌

Results for commit 2ef9849.

@anxodio anxodio requested a review from a team January 8, 2025 14:28
@anxodio
Copy link
Contributor Author

anxodio commented Jan 9, 2025

Sobre el test skipped:

El tema es que falla perque la forma de pagament no es correcte, i en aquest test no es toca res de forma de pagaments, i vaig estar 20 minuts intentant mirar si ho podia resoldre i se m'escapa com deu estar configurat, pero clarament es algo de les dades de test perque a produccio ningu s'ha queixat de que falli aixo

@anxodio anxodio merged commit 2bab86c into master Jan 9, 2025
6 checks passed
@anxodio anxodio deleted the fix_failing_tests branch January 9, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants