Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 set language at i18n if maintenance screen #113

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

marta197
Copy link
Contributor

Description

Maintenance screen language depended on user's navigator language.

Changes

  • First, get url language to set i18n language.

Checklist

Justify any unchecked point:

  • Changed code is covered by tests.
  • Relevant changes are explained in the "Unreleased" section of the CHANGES.md file: N/A
  • That section includes "Upgrade notes" with any config, dependency or deploy tweek needed on development and server setups: N/A
  • Changes on the setup process (development, testing, production) have been updated in the proper documentation: N/A

Observations

Please, review

  • Tests pass
  • The language of the url sets the maintenance screen language.

@marta197 marta197 added the bug Something isn't working label Jan 28, 2025
@marta197 marta197 requested a review from BenjiRS94 January 28, 2025 09:47
@marta197 marta197 self-assigned this Jan 28, 2025
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webforms-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:47am

@marta197 marta197 merged commit 6c22647 into master Jan 28, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants