Add rule S6807 (jsx-a11y/role-has-required-aria-props): DOM element…

…s with ARIA roles should have the required properties (#4262)

its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1451.json

@@ -179,6 +179,9 @@
 "file-for-rules:S6766.js": [
 0
 ],
+"file-for-rules:S6807.js": [
+0
+],
 "file-for-rules:boundOrAssignedEvalOrArguments.js": [
 0
 ]

its/ruling/src/test/expected/jsts/file-for-rules/javascript-S3798.json

@@ -56,6 +56,9 @@
 "file-for-rules:S6766.js": [
 2
 ],
+"file-for-rules:S6807.js": [
+2
+],
 "file-for-rules:boundOrAssignedEvalOrArguments.js": [
 2,
 8

its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6807.json

@@ -0,0 +1,5 @@
+{
+"file-for-rules:S6807.js": [
+4
+]
+}

its/sources/jsts/custom/S6807.js

@@ -0,0 +1,6 @@
+import React from 'react';
+function MyComponent(){
+  return (
+    <div role="checkbox">{/* Noncompliant: aria-checked is missing */} Unchecked</div>
+  );
+}

package.json

@@ -81,6 +81,7 @@
     "builtin-modules": "3.3.0",
     "bytes": "3.1.2",
     "eslint": "8.47.0",
+    "eslint-plugin-jsx-a11y": "6.7.1",
     "eslint-plugin-react": "7.33.2",
     "eslint-plugin-react-hooks": "4.6.0",
     "eslint-plugin-sonarjs": "0.21.0",
@@ -116,6 +117,7 @@
     "builtin-modules",
     "bytes",
     "eslint",
+    "eslint-plugin-jsx-a11y",
     "eslint-plugin-react",
     "eslint-plugin-react-hooks",
     "eslint-plugin-sonarjs",

packages/jsts/src/linter/bundle-loader.ts

@@ -22,6 +22,7 @@ import { eslintRules } from '../rules/core';
 import { tsEslintRules } from '../rules/typescript-eslint';
 import { rules as pluginRules } from 'eslint-plugin-sonarjs';
 import { rules as reactESLintRules } from 'eslint-plugin-react';
+import { rules as reactA11yRules } from 'eslint-plugin-jsx-a11y';
 import { rules as internalRules } from '../rules';
 import { customRules as internalCustomRules, CustomRule } from './custom-rules';
 import { debug, getContext } from '@sonar/shared/helpers';
@@ -57,7 +58,7 @@ const loaders: { [key: string]: Function } = {
      * Core ESLint rules could be overridden by the implementation from specific
      * dependencies, which should be the default behaviour in most cases.
      */
-    const dependencies = [eslintRules, tsEslintRules, reactESLintRules];
+    const dependencies = [eslintRules, tsEslintRules, reactESLintRules, reactA11yRules];
     for (const dependencyRules of dependencies) {
       for (const [name, module] of Object.entries(dependencyRules)) {
         externalRules[name] = module;

sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/CheckList.java

@@ -371,6 +371,7 @@ public static List<Class<? extends JavaScriptCheck>> getAllChecks() {
       RequireRenderReturnCheck.class,
       ReturnInSetterCheck.class,
       ReturnOfBooleanExpressionCheck.class,
+      RoleHasRequiredAriaPropsCheck.class,
       RulesOfHooksCheck.class,
       SameLineConditionalCheck.class,
       SelfAssignmentCheck.class,