JS-20 - Fix FP S6754 (hook-use-state): Add exception when using `us…

…eState` for components
SonarSource · Jan 6, 2025 · 7a25560 · 7a25560
1 parent c7f5058
commit 7a25560
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 3 deletions.
diff --git a/packages/jsts/src/rules/S6754/decorator.ts b/packages/jsts/src/rules/S6754/decorator.ts
@@ -19,6 +19,7 @@
 import type { Rule } from 'eslint';
 import { generateMeta, interceptReportForReact } from '../helpers/index.js';
 import { meta } from './meta.js';
+import { Node } from 'estree';
 
 export function decorate(rule: Rule.RuleModule): Rule.RuleModule {
   return interceptReportForReact(
@@ -27,9 +28,27 @@ export function decorate(rule: Rule.RuleModule): Rule.RuleModule {
       meta: generateMeta(meta as Rule.RuleMetaData, rule.meta),
     },
     (context, descriptor) => {
-      const { node } = descriptor as any;
-      if (node.type === 'ArrayPattern' && node.elements.length === 1) {
-        return;
+      const { node } = descriptor as {
+        node: Node;
+      };
+
+      console.log(descriptor);
+
+      if (node.type === 'ArrayPattern') {
+        if (node.elements.length === 1) {
+          return;
+        }
+
+        const [getter, setter] = node.elements;
+
+        if (getter?.type === 'Identifier' && setter?.type === 'Identifier') {
+          const getterName = getter.name;
+          const setterName = setter.name;
+
+          if (setterName.startsWith('set') && setterName.substring(3) === getterName) {
+            return;
+          }
+        }
       }
       context.report(descriptor);
     },

diff --git a/packages/jsts/src/rules/S6754/unit.test.ts b/packages/jsts/src/rules/S6754/unit.test.ts
@@ -33,6 +33,20 @@ ruleTester.run(
         return [foo];
       }`,
       },
+      {
+        code: `
+      import { useState } from 'react';
+      function useFoo() {
+        const [foo, setFoo] = useState();
+      }`,
+      },
+      {
+        code: `
+      import { useState } from 'react';
+      function useFoo() {
+        const [Foo, setFoo] = useState();
+      }`,
+      },
     ],
     invalid: [
       {
@@ -44,6 +58,14 @@ ruleTester.run(
       }`,
         errors: 1,
       },
+      {
+        code: `
+      import { useState } from 'react';
+      function useFoo() {
+        const getterAndSetter = useState();
+      }`,
+        errors: 1,
+      },
     ],
   },
 );