Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only accept supported web languages for CSS analysis (and activate SASS by default) #4308

Merged
merged 14 commits into from
Oct 25, 2023
Merged

Only accept supported web languages for CSS analysis (and activate SASS by default) #4308

merged 14 commits into from
Oct 25, 2023

Conversation

ilia-kebets-sonarsource
Copy link
Contributor

Fixes #4230

@ilia-kebets-sonarsource ilia-kebets-sonarsource changed the title declare all used languages: only standard and ones that our configured stylelint supports CSS: only accept standard languages Oct 24, 2023
@ilia-kebets-sonarsource ilia-kebets-sonarsource marked this pull request as ready for review October 24, 2023 12:00
@ilia-kebets-sonarsource ilia-kebets-sonarsource changed the title CSS: only accept standard languages CSS: only accept standard languages (and activate SASS by default) Oct 24, 2023
yassin-kammoun-sonarsource
yassin-kammoun-sonarsource approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you try to improve the PR's title, something that would fit in:
This commit should <description>.

its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/CssMetricsTest.java Show resolved Hide resolved
its/ruling/src/test/java/org/sonar/javascript/it/CssRulingTest.java Outdated Show resolved Hide resolved
...sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/CssRuleSensor.java Outdated Show resolved Hide resolved
@ilia-kebets-sonarsource ilia-kebets-sonarsource changed the title CSS: only accept standard languages (and activate SASS by default) Only accept supported web languages for CSS analysis (and activate SASS by default) Oct 25, 2023
@sonarqube-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

yassin-kammoun-sonarsource
yassin-kammoun-sonarsource approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that updating Stylelint didn't fix the duplicated issues for some rules on ruling. However, we now know that some rules could raise duplicates. I think it's acceptable for now, as we can't do much since those are Stylelint rules. However, we might need to take some actions if users start complaining about these in case they occur a lot.

@ilia-kebets-sonarsource ilia-kebets-sonarsource merged commit 2472b76 into master Oct 25, 2023
19 checks passed
@ilia-kebets-sonarsource ilia-kebets-sonarsource deleted the issue-4230/parse-only-valid-css-formats branch October 25, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource yassin-kammoun-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS: only parse supported formats
3 participants
@ilia-kebets-sonarsource @yassin-kammoun-sonarsource @kebetsi